From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dirk Brandewie <dirk.brandewie@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
cpufreq <cpufreq@vger.kernel.org>
Subject: Re: [PATCH] intel_pstate: Use del_timer_sync in intel_pstate_cpu_stop
Date: Tue, 25 Mar 2014 09:58:46 +0530 [thread overview]
Message-ID: <CAOh2x=m9C77gYFbxQ1fn-ebQdL58OhY60rXq6WHyTR4Wau7_QA@mail.gmail.com> (raw)
In-Reply-To: <1395672089-19336-1-git-send-email-dirk.j.brandewie@intel.com>
On Mon, Mar 24, 2014 at 8:11 PM, <dirk.brandewie@gmail.com> wrote:
> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
>
> Ensure that no timer callback is running since we are about to free
> the timer structure. We cannot guarantee that the call back is called
> on the CPU where the timer is running.
>
> Reported-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: cpufreq <cpufreq@vger.kernel.org>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index e9092fd..a4a9ba5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -780,7 +780,7 @@ static int intel_pstate_cpu_stop(struct cpufreq_policy *policy)
>
> pr_info("intel_pstate CPU %d exiting\n", cpu_num);
>
> - del_timer(&all_cpu_data[cpu_num]->timer);
> + del_timer_sync(&all_cpu_data[cpu_num]->timer);
> intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);
> kfree(all_cpu_data[cpu_num]);
> all_cpu_data[cpu_num] = NULL;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
prev parent reply other threads:[~2014-03-25 4:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 14:41 [PATCH] intel_pstate: Use del_timer_sync in intel_pstate_cpu_stop dirk.brandewie
2014-03-24 14:54 ` Srivatsa S. Bhat
2014-03-25 4:28 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOh2x=m9C77gYFbxQ1fn-ebQdL58OhY60rXq6WHyTR4Wau7_QA@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).