From: Jakub Kicinski <kuba@kernel.org>
To: dccp@vger.kernel.org
Subject: Re: [PATCH] dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock
Date: Fri, 29 Jul 2022 15:44:48 +0000 [thread overview]
Message-ID: <20220729084448.5a4492cc@kernel.org> (raw)
In-Reply-To: <20220727080609.26532-1-hbh25y@gmail.com>
On Fri, 29 Jul 2022 18:34:39 +0800 Hangyu Hua wrote:
> >> thread1--->lock
> >> thread1--->dccp_qpolicy_full: queue is full. drop a skb
> >
> > This linie should say "not full"?
>
> dccp_qpolicy_full only call dccp_qpolicy_drop when queue is full. You
> can check out qpolicy_prio_full. qpolicy_prio_full will drop a skb to
> make suer there is enough space for the next data. So I think it should
> be "full" here.
Oh, I see what you're saying. That's unnecessarily complicated,
I reckon. The "simple" policy suffers from the same problem and
is easier to understand. Anyway, you already sent v2 and it doesn't
matter enough to warrant v3, so fine.
prev parent reply other threads:[~2022-07-29 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 8:06 [PATCH] dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock Hangyu Hua
2022-07-29 2:59 ` Jakub Kicinski
2022-07-29 10:34 ` Hangyu Hua
2022-07-29 15:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729084448.5a4492cc@kernel.org \
--to=kuba@kernel.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).