From: Dan Carpenter <dan.carpenter@linaro.org>
To: dccp@vger.kernel.org
Subject: [PATCH net] dccp: Allocate enough data in ccid_get_builtin_ccids()
Date: Wed, 26 Jul 2023 10:47:02 +0000 [thread overview]
Message-ID: <35ed2523-49ee-4e2b-b50d-38508f74f93f@moroto.mountain> (raw)
This is allocating the ARRAY_SIZE() instead of the number of bytes. The
array size is 1 or 2 depending on the .config and it should allocate
8 or 16 bytes instead.
Fixes: ddebc973c56b ("dccp: Lockless integration of CCID congestion-control plugins")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
net/dccp/ccid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/dccp/ccid.c b/net/dccp/ccid.c
index 6beac5d348e2..9067958d3857 100644
--- a/net/dccp/ccid.c
+++ b/net/dccp/ccid.c
@@ -48,7 +48,8 @@ bool ccid_support_check(u8 const *ccid_array, u8 array_len)
*/
int ccid_get_builtin_ccids(u8 **ccid_array, u8 *array_len)
{
- *ccid_array = kmalloc(ARRAY_SIZE(ccids), gfp_any());
+ *ccid_array = kmalloc_array(ARRAY_SIZE(ccids), sizeof(*ccid_array),
+ gfp_any());
if (*ccid_array = NULL)
return -ENOBUFS;
--
2.39.2
next reply other threads:[~2023-07-26 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 10:47 Dan Carpenter [this message]
2023-07-26 12:56 ` [PATCH net] dccp: Allocate enough data in ccid_get_builtin_ccids() Simon Horman
2023-07-26 12:59 ` Simon Horman
2023-07-26 13:45 ` Dan Carpenter
2023-07-27 11:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ed2523-49ee-4e2b-b50d-38508f74f93f@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).