From: David Howells <dhowells@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)
Date: Wed, 29 Mar 2023 14:39:33 +0000 [thread overview]
Message-ID: <518631.1680100773@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230329141354.516864-49-dhowells@redhat.com>
Hannes Reinecke <hare@suse.de> wrote:
> > [!] Note: This is a work in progress. At the moment, some things won't
> > build if this patch is applied. nvme, kcm, smc, tls.
Actually, that needs updating. nvme and smc now build.
> Weelll ... what happens to consumers of kernel_sendpage()?
> (Let's call them nvme ...)
> Should they be moved over, too?
Patch 42 should address NVMe, I think. I can't test it, though, as I don't
have hardware.
There should be no callers of kernel_sendmsg() by the end of this patchset,
and the only remaining implementors of sendpage are Chelsio-TLS, AF_TLS and
AF_KCM, which as stated in the cover, aren't yet converted and won't build.
> Or what is the general consensus here?
>
> (And what do we do with TLS? It does have a ->sendpage() version, too ...)
I know. There are three things left that I need to tackle, but I'd like to
get opinions on some of the other bits and I might need some help with AF_TLS
and AF_KCM.
That said, should I just remove tls_sw_do_sendpage() since presumably the data
is going to get copied(?) and encrypted and the source pages aren't going to
be held onto?
David
prev parent reply other threads:[~2023-03-29 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 14:13 [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) David Howells
2023-03-29 14:23 ` Hannes Reinecke
2023-03-29 14:39 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518631.1680100773@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).