From: Joanne Koong <joannelkoong@gmail.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/2] net: Update bhash2 when socket's rcv saddr changes
Date: Wed, 01 Jun 2022 18:31:08 +0000 [thread overview]
Message-ID: <CAJnrk1bkLFwAmmQviJeeHKSHygUqG8LH81RYnx6+mJOLZF8tjw@mail.gmail.com> (raw)
In-Reply-To: <CANn89i+pg8guF+XeOngSMa4vUD81g=u-pCBpi0Yp2WB9PQZvdg@mail.gmail.com>
On Wed, Jun 1, 2022 at 2:58 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hello,
>
> On Tue, 2022-05-31 at 15:04 -0700, Eric Dumazet wrote:
> > On Tue, May 24, 2022 at 4:20 PM Joanne Koong <joannelkoong@gmail.com> wrote:
> > >
> > > Commit d5a42de8bdbe ("net: Add a second bind table hashed by port and
> > > address") added a second bind table, bhash2, that hashes by a socket's port
> > > and rcv address.
> > >
> > > However, there are two cases where the socket's rcv saddr can change
> > > after it has been binded:
> > >
> > > 1) The case where there is a bind() call on "::" (IPADDR_ANY) and then
> > > a connect() call. The kernel will assign the socket an address when it
> > > handles the connect()
> > >
> > > 2) In inet_sk_reselect_saddr(), which is called when rerouting fails
> > > when rebuilding the sk header (invoked by inet_sk_rebuild_header)
> > >
> > > In these two cases, we need to update the bhash2 table by removing the
> > > entry for the old address, and adding a new entry reflecting the updated
> > > address.
> > >
> > > Reported-by: syzbot+015d756bbd1f8b5c8f09@syzkaller.appspotmail.com
> > > Fixes: d5a42de8bdbe ("net: Add a second bind table hashed by port and address")
> > > Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> > > ---
> >
> > Reviewed-by: Eric Dumazet <edumzet@google.com>
> >
> Apparently this patch (and 2/2) did not reach the ML nor patchwork (let
> alone my inbox ;). I've no idea on the root cause, sorry.
>
> @Joanne: could you please re-post the series? (you can retain Eric's
> review tag)
>
For some reason, my patches recently haven't been getting through to
the netdev mailing list but they've been going through ok to the bpf
one; John, Jakub, and I are looking into it and doing some
investigations :)
I will resend this series again.
Thanks for taking a look at this patchset, Eric and Paolo.
> Thanks!
>
> Paolo
>
prev parent reply other threads:[~2022-06-01 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 22:04 [PATCH net-next v1 1/2] net: Update bhash2 when socket's rcv saddr changes Eric Dumazet
2022-06-01 9:58 ` Paolo Abeni
2022-06-01 18:31 ` Joanne Koong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJnrk1bkLFwAmmQviJeeHKSHygUqG8LH81RYnx6+mJOLZF8tjw@mail.gmail.com \
--to=joannelkoong@gmail.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).