From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Tom Turelinckx <tom-HiypchcOusz53ZRCpReHOg@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: bus error on sparc64 running type-preservation test
Date: Tue, 21 Apr 2020 13:22:04 +1000 [thread overview]
Message-ID: <20200421032204.GD52174@umbus.fritz.box> (raw)
In-Reply-To: <4c0be4b4-7f6e-4612-af7b-dfffb400597a-jFIJ+Wc5/Vo7lZ9V/NTDHw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]
On Tue, Apr 14, 2020 at 06:34:24PM +0200, Tom Turelinckx wrote:
> Hi,
>
> On Tue, Apr 14, 2020, at 8:25 AM, David Gibson wrote:
> > I've just merged and pushed a change which I think will fix this to
> > the master branch. Could you build and test that please?
>
> It seems to work, thanks!
>
> I've verified on debian sparc64 that make and make check succeed when I checkout b28464a, while make check fails with bus error when I checkout 87a656a.
>
> I've also verified that the debian src package version 1.6.0-1 builds successfully on sparc64 with patch b28464a applied locally, and that the same package with the same patch applied still builds successfully on amd64. Those are the only archs I have access to.
>
> > If you can make a minimal testcase which triggers this problem and
> > submit it as an addition to the dtc testsuite, that would be terrific.
>
> I have limited experience with C development, and zero experience
> with alignment issues, DTC or its test suite, so I can't be of much
> help here...
The relevant part of the test suite is nearly all shell. But I
realized this isn't actually relevant anyway. I thought the problem
was that we didn't have a test which exercised this unaligned case -
but you said it tripped on the type preservation test, so there is a
testcase there already. I assume it wasn't caught before just because
sparc64 is more sensitive to misaligned loads than on the archs I
generally build for. I would have thought ARM would have caught it,
but apparently not. I can't think of any easy way to extend the
testsuite to handle that, so there's not really anything to be done
here.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-04-21 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 16:09 bus error on sparc64 running type-preservation test Tom Turelinckx
2020-04-13 16:29 ` Tom Turelinckx
2020-04-14 6:25 ` David Gibson
[not found] ` <20200414062534.GL48061-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-04-14 16:34 ` Tom Turelinckx
[not found] ` <4c0be4b4-7f6e-4612-af7b-dfffb400597a-jFIJ+Wc5/Vo7lZ9V/NTDHw@public.gmane.org>
2020-04-21 3:22 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421032204.GD52174@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tom-HiypchcOusz53ZRCpReHOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).