From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Subject: Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
Date: Thu, 21 May 2020 15:09:14 +1000 [thread overview]
Message-ID: <20200521050914.GE63349@umbus.fritz.box> (raw)
In-Reply-To: <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]
On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> dtc does a sanity check on reg properties that they are within the 10
> bit address range for i2c slave addresses. In the case of multi-master
> buses the binding may describe an address that the bus will listen on as
> a device. Do not warn when this flag is set.
>
> This fixes the following build warnings reported by Stephen:
>
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> I2C bus unit address format error, expected "40000010"
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> I2C address must be less than 10-bits, got "0x40000010"
>
> Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
Any document you can give a pointer two explaining the special meaning
of this bit?
> ---
> checks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/checks.c b/checks.c
> index a8213c0e13a8..2c23dd4f7778 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1022,6 +1022,8 @@ static void check_i2c_bus_bridge(struct check *c, struct dt_info *dti, struct no
> }
> WARNING(i2c_bus_bridge, check_i2c_bus_bridge, NULL, &addr_size_cells);
>
> +#define I2C_OWN_SLAVE_ADDRESS (1 << 30)
> +
> static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
> {
> struct property *prop;
> @@ -1044,6 +1046,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
> }
>
> reg = fdt32_to_cpu(*cells);
> + /* Ingore I2C_OWN_SLAVE_ADDRESS */
Also, s/Ingore/Ignore/g
> + reg &= ~I2C_OWN_SLAVE_ADDRESS;
> snprintf(unit_addr, sizeof(unit_addr), "%x", reg);
> if (!streq(unitname, unit_addr))
> FAIL(c, dti, node, "I2C bus unit address format error, expected \"%s\"",
> @@ -1051,6 +1055,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
>
> for (len = prop->val.len; len > 0; len -= 4) {
> reg = fdt32_to_cpu(*(cells++));
> + /* Ingore I2C_OWN_SLAVE_ADDRESS */
> + reg &= ~I2C_OWN_SLAVE_ADDRESS;
> if (reg > 0x3ff)
> FAIL_PROP(c, dti, node, prop, "I2C address must be less than 10-bits, got \"0x%x\"",
> reg);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-21 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:51 [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS Joel Stanley
[not found] ` <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2020-05-21 5:09 ` David Gibson [this message]
[not found] ` <20200521050914.GE63349-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-05-21 6:50 ` Stephen Rothwell
[not found] ` <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2020-05-22 7:48 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521050914.GE63349@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).