From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Andre Przywara <andre.przywara@arm.com>,
Bin Meng <bmeng.cn@gmail.com>,
Dalon Westergreen <dalon.westergreen@intel.com>,
Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Walter Lozano <walter.lozano@collabora.com>
Subject: [PATCH v2 0/6] Makefile: Tidy up of-platdata file generation rules
Date: Thu, 25 Mar 2021 06:40:47 +1300 [thread overview]
Message-ID: <20210324174053.4180445-1-sjg@chromium.org> (raw)
The recent of-platdata implementation has caused an occasional error in
CI, possibly due to the transition between !OF_PLATDATA_INST and
OF_PLATDATA_INST.
The problems seems to be due to a generated file (C or object file) not
being regenerated when the setting changes.
This series take two steps aimed at correct this problem.
Firstly it makes the set of files generated (in each case) mutually
exclusive, except for the header files which remain common. This means
that the build will fail if new files are not generated when the setting
changes.
Secondly it removes the old generated files before building new ones,
since that could trip things up if the flag changes back again in a
subsequent build.
In addition, dtoc is currently running on every of-platadata build, even
if nothing has changed. Also pylibfdt is always built due to a change in
file naming with Python 3. Both of these problems are fixed.
Changes in v2:
- Adjust tag so this patch doesn't got to dtc list
- Add a comment to the endif
- Only remove the old (and to be unused) files, so avoid confusing make
Simon Glass (6):
libfdt: Tidy up pylibfdt build rule
Makefile: Avoid running dtoc every time
Makefile: Depend only on required of-platdata files
dtoc: Only generate the required files
Makefile: Use a variable for generated of-platdata headers
Makefile: Remove old of-platdata files before regenerating
scripts/Makefile.spl | 43 ++++++++++++++++++++++++-----------
scripts/dtc/pylibfdt/Makefile | 8 +++++--
tools/dtoc/dtb_platdata.py | 23 +++++++++++++++----
tools/dtoc/test_dtoc.py | 2 +-
4 files changed, 56 insertions(+), 20 deletions(-)
--
2.31.0.291.g576ba9dcdaf-goog
next reply other threads:[~2021-03-24 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 17:40 Simon Glass [this message]
2021-03-24 17:40 ` [PATCH v2 1/6] libfdt: Tidy up pylibfdt build rule Simon Glass
[not found] ` <20210324174053.4180445-2-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2021-03-26 3:18 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324174053.4180445-1-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=andre.przywara@arm.com \
--cc=bmeng.cn@gmail.com \
--cc=dalon.westergreen@intel.com \
--cc=devicetree-compiler@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=masahiroy@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=walter.lozano@collabora.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).