From: Frank Mehnert <frank.mehnert-2ptZNfhJYoRaodhZ+FW2PA@public.gmane.org>
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Subject: [PATCH] libfdt: fix fdt_check_node_offset_ w/ VALID_INPUT
Date: Thu, 13 Aug 2020 09:55:09 +0200 [thread overview]
Message-ID: <76064614.bJBAheWMra@noys4> (raw)
fdt_check_node_offset_() checks for a valid offset but also changes the
offset by calling fdt_next_tag(). Hence, do not skip this function if
ASSUME_VALID_INPUT is set.
Actually this works similar to fdt_check_prop_offset_().
---
libfdt/fdt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libfdt/fdt.c b/libfdt/fdt.c
index c28fcc1..39ed8ed 100644
--- a/libfdt/fdt.c
+++ b/libfdt/fdt.c
@@ -206,8 +206,6 @@ uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
int fdt_check_node_offset_(const void *fdt, int offset)
{
- if (can_assume(VALID_INPUT))
- return offset;
if ((offset < 0) || (offset % FDT_TAGSIZE)
|| (fdt_next_tag(fdt, offset, &offset) != FDT_BEGIN_NODE))
return -FDT_ERR_BADOFFSET;
next reply other threads:[~2020-08-13 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:55 Frank Mehnert [this message]
2020-08-13 9:51 ` [PATCH] libfdt: fix fdt_check_node_offset_ w/ VALID_INPUT David Gibson
[not found] ` <20200813095108.GA181791-l+x2Y8Cxqc4e6aEkudXLsA@public.gmane.org>
2020-08-13 15:26 ` Frank Mehnert
2020-08-14 3:17 ` David Gibson
[not found] ` <20200814031748.GA12805-l+x2Y8Cxqc4e6aEkudXLsA@public.gmane.org>
2020-08-14 6:47 ` Frank Mehnert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76064614.bJBAheWMra@noys4 \
--to=frank.mehnert-2ptznfhjyoraodhz+fw2pa@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).