From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2] checks: Suppress warnings on overlay fragments
Date: Thu, 9 Mar 2023 09:12:41 -0600 [thread overview]
Message-ID: <CAL_JsqKTM=gaQGZhrBCRkBusYYMci0mJGAFf9RTvCx00G2OJzg@mail.gmail.com> (raw)
In-Reply-To: <20230308091539.11178-1-qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Wed, Mar 8, 2023 at 3:17 AM Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcLQFizaE/u3fw@public.gmane.orgm> wrote:
>
> The overlay fragment is a special case where some properties are not
> present in the overlay source file, but in the base file.
>
> example:
> +-----------------------------+--------------------+
> | base.dts | overlay.dts |
> +-----------------------------+--------------------+
> | /dts-v1/; | /dts-v1/; |
> | | /plugin/; |
> | /{ | |
> | parent: test { | &parent { |
> | #address-cells = <1>; | child@0 { |
> | #size-cells = <0>; | reg = <0x0>; |
> | }; | }; |
> | }; | }; |
> +-----------------------------+--------------------+
>
> It will cause the following false alarms when compiling the overlay dts.
>
> 1. /fragment@0/__overlay__: Character '_' not recommended in node name
> 2. /fragment@0/__overlay__: Relying on default #address-cells value
> 3. /fragment@0/__overlay__: Relying on default #size-cells value
> 4. /fragment@0/__overlay__:reg: property has invalid length (4 bytes)
> (#address-cells == 2, #size-cells == 1)
>
> This workaround will fix them by skip checking for node named __overlay__.
>
> Signed-off-by: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> V1 -> V2:
> - Add is_overlay_node() helper
> - Skip anything starting with "__" in check_node_name_chars_strict()
>
> checks.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Though I do wonder if as a matter of policy on overlay structure, if
we should require an overlay to have the parent node with
#address-cells/#size-cells. In the end that would be duplicated data,
but without it there's no way to parse and validate reg/ranges in an
unapplied overlay. That's just one example issue in being able to
validate overlays.
Rob
next prev parent reply other threads:[~2023-03-09 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:15 [PATCH v2] checks: Suppress warnings on overlay fragments Qun-Wei Lin
[not found] ` <20230308091539.11178-1-qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2023-03-09 15:12 ` Rob Herring [this message]
[not found] ` <CAL_JsqKTM=gaQGZhrBCRkBusYYMci0mJGAFf9RTvCx00G2OJzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-04-13 12:43 ` Qun-wei Lin (林群崴)
[not found] ` <347151917fb777e66a54e983efbbe0303f63e01a.camel-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2023-04-18 17:33 ` Rob Herring
[not found] ` <CAL_Jsq+L50RZ-s55tncFMHA1AwL5An13n2OVPzknnpu=uOvzhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-14 6:42 ` david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+
2024-01-16 12:54 ` Roger Quadros
2024-01-22 16:01 ` Rob Herring
2024-01-23 14:49 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKTM=gaQGZhrBCRkBusYYMci0mJGAFf9RTvCx00G2OJzg@mail.gmail.com' \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).