From: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Luca Weiss <luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] pylibfdt: add size_hint parameter for get_path
Date: Wed, 1 Feb 2023 13:20:51 -0700 [thread overview]
Message-ID: <CAPnjgZ1hHkTuAiUwxPuTeWTeJX1Sju2tnZz-pCyBY0BeW6cYhg@mail.gmail.com> (raw)
In-Reply-To: <20230201181112.1644842-1-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
Hi Luca,
On Wed, 1 Feb 2023 at 11:16, Luca Weiss <luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org> wrote:
>
> This also enables us to test the -NOSPACE condition by adding a test
> setting size_hint=1 so this path is taken.
> ---
> Follow-up from "pylibfdt: add FdtRo.get_path()" from April 2022
>
> pylibfdt/libfdt.i | 8 ++++----
> tests/pylibfdt_tests.py | 1 +
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
Can you add a motivation for this? Why are the paths so long?
Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i
> index f9f7e7e..0c80c54 100644
> --- a/pylibfdt/libfdt.i
> +++ b/pylibfdt/libfdt.i
> @@ -443,11 +443,12 @@ class FdtRo(object):
> """
> return fdt_get_alias(self._fdt, name)
>
> - def get_path(self, nodeoffset, quiet=()):
> + def get_path(self, nodeoffset, size_hint=1024, quiet=()):
> """Get the full path of a node
>
> Args:
> nodeoffset: Node offset to check
> + size_hint: Hint for size of returned string
>
> Returns:
> Full path to the node
> @@ -455,11 +456,10 @@ class FdtRo(object):
> Raises:
> FdtException if an error occurs
> """
> - size = 1024
> while True:
> - ret, path = fdt_get_path(self._fdt, nodeoffset, size)
> + ret, path = fdt_get_path(self._fdt, nodeoffset, size_hint)
> if ret == -NOSPACE:
> - size = size * 2
> + size_hint *= 2
> continue
> err = check_err(ret, quiet)
> if err:
> diff --git a/tests/pylibfdt_tests.py b/tests/pylibfdt_tests.py
> index 68d6aaa..34c2764 100644
> --- a/tests/pylibfdt_tests.py
> +++ b/tests/pylibfdt_tests.py
> @@ -354,6 +354,7 @@ class PyLibfdtBasicTests(unittest.TestCase):
> node2 = self.fdt.path_offset('/subnode@1/subsubnode')
> self.assertEqual("/subnode@1", self.fdt.get_path(node))
> self.assertEqual("/subnode@1/subsubnode", self.fdt.get_path(node2))
> + self.assertEqual("/subnode@1/subsubnode", self.fdt.get_path(node2, size_hint=1))
>
> with self.assertRaises(FdtException) as e:
> self.fdt.get_path(-1)
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-02-01 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 18:11 [PATCH] pylibfdt: add size_hint parameter for get_path Luca Weiss
[not found] ` <20230201181112.1644842-1-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2023-02-01 20:20 ` Simon Glass [this message]
[not found] ` <CAPnjgZ1hHkTuAiUwxPuTeWTeJX1Sju2tnZz-pCyBY0BeW6cYhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-02-02 6:38 ` David Gibson
2023-02-02 17:08 ` Luca Weiss
[not found] ` <2060136.KlZ2vcFHjT-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2023-02-02 17:13 ` Simon Glass
2023-02-05 6:32 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1hHkTuAiUwxPuTeWTeJX1Sju2tnZz-pCyBY0BeW6cYhg@mail.gmail.com \
--to=sjg-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).