devicetree-compiler.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Vincent Pelletier <plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: dtc 1.6.0 overlay full-path reference in array produces broken property names
Date: Wed, 29 Sep 2021 11:40:49 +1000	[thread overview]
Message-ID: <YVPEIdIYGhxl9SrJ@yekko> (raw)
In-Reply-To: <20210928112859.79b55d5a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On Tue, Sep 28, 2021 at 11:28:59AM +0000, Vincent Pelletier wrote:
> On Mon, 27 Sep 2021 14:04:56 +0000, Vincent Pelletier <plr.vincent@gmail.com> wrote:
> > (please keep me cc'ed in replies)
> [...]
> > This code builds fine:
> >   $ dtc -I dts -O dtb -o test.dtbo test.dts
> >   $
> > But then when disassembling the output, I get:
> >   $ dtc -I dtb -O dts test.dtbo
> >   <stdout>: ERROR (property_name_chars): /__fixups__:/soc/gpio@7e200000: Bad character '/' in property name
> >   ERROR: Input tree has errors, aborting (use -f to force output)
> 
> I just noticed 1.6.1 was released (but not packaged yet by my
> distribution, it seems), so I reproduced from git master as of
> 
>   commit e33ce1d6a8c7e54e3ad12cff33690b6da0aee1dc (HEAD -> master, origin/master, origin/main, origin/HEAD)
>   Author: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
>   Date:   Fri Sep 24 23:39:56 2021 +1000
> 
>       flattree: Use '\n', not ';' to separate asm pseudo-ops
> 
> and I confirm the error is still present.

Thanks for checking, and yes, this definitely looks like a dtc bug.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-09-29  1:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 14:04 dtc 1.6.0 overlay full-path reference in array produces broken property names Vincent Pelletier
     [not found] ` <20210927140456.4e45f05b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-28 11:28   ` Vincent Pelletier
     [not found]     ` <20210928112859.79b55d5a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-29  1:40       ` David Gibson [this message]
2021-11-01  6:19   ` David Gibson
2022-07-31 12:12     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVPEIdIYGhxl9SrJ@yekko \
    --to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
    --cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).