From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/6] pylibfdt_tests: Don't depend on built dtbs
Date: Fri, 12 Nov 2021 15:57:05 +1100 [thread overview]
Message-ID: <YY30Ibyru+HjNaPV@yekko> (raw)
In-Reply-To: <20211112041633.741598-4-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On Thu, Nov 11, 2021 at 10:16:30PM -0600, Rob Herring wrote:
> The pylibfdt tests depend on the rest of the tests to build dtbs, but
> are otherwise independent. Modify the test to build dtbs itself so the
> python tests can run standalone.
>
> This also fixes an intermittent problem with the DT strings section size
> varying depending on how the dtb was built. The test assumed the dtb was
> built with '-H both' option which is pretty much impossible to tell from
> run_tests.sh.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
This breaks "make check" for me. I think it's relying on there being
an already built dtc in the path, rather than specifically running the
dtc built from the source tree.
======================================================================
ERROR: testAccess (__main__.PyLibfdtRoTests)
Basic sanity check for the FdtRo class
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/dwg/src/dtc/tests/./pylibfdt_tests.py", line 583, in setUp
dtb = subprocess.run(['dtc', '-O', 'dtb', os.path.join(testsrc, 'test_tree1.dts')],
File "/usr/lib64/python3.10/subprocess.py", line 501, in run
with Popen(*popenargs, **kwargs) as process:
File "/usr/lib64/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib64/python3.10/subprocess.py", line 1842, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'dtc'
----------------------------------------------------------------------
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-12 4:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 4:16 [PATCH 0/6] More pylibfdt updates Rob Herring
[not found] ` <20211112041633.741598-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-11-12 4:16 ` [PATCH 1/6] README: Update pylibfdt install instructions Rob Herring
2021-11-12 4:16 ` [PATCH 2/6] pylibfdt: Add packaging metadata Rob Herring
2021-11-12 4:16 ` [PATCH 3/6] pylibfdt_tests: Don't depend on built dtbs Rob Herring
[not found] ` <20211112041633.741598-4-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-11-12 4:57 ` David Gibson [this message]
2021-11-12 4:16 ` [PATCH 4/6] tests: rename pylibfdt_tests.py to test_pylibfdt.py Rob Herring
2021-11-12 4:16 ` [PATCH 5/6] pylibfdt: Include tests and test data in packaging Rob Herring
2021-11-12 4:16 ` [PATCH 6/6] pylibfdt: Add tox support Rob Herring
2021-11-12 6:10 ` [PATCH 0/6] More pylibfdt updates David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY30Ibyru+HjNaPV@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).