From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
entwicklung-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v3] dtc: Add an option to generate __local_fixups__ and __fixups__
Date: Sat, 27 May 2023 11:54:53 +1000 [thread overview]
Message-ID: <ZHFi7X09bHW4Wts/@yekko> (raw)
In-Reply-To: <20230523080941.419330-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 3385 bytes --]
On Tue, May 23, 2023 at 10:09:41AM +0200, Uwe Kleine-König wrote:
> This records detailed usage of labels in a dtb. This is needed in
> overlays (and enabled implicitly for these). For ordinary device trees
> it can be used to restore labels when compiling back to dts format.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied, thanks.
> ---
> Documentation/manual.txt | 14 ++++++++++++++
> dtc.c | 8 +++++++-
> 2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/manual.txt b/Documentation/manual.txt
> index 15a7837d3cef..598c6e694c55 100644
> --- a/Documentation/manual.txt
> +++ b/Documentation/manual.txt
> @@ -126,6 +126,20 @@ Options:
> property for each label. The property's name is the label name and the
> value is the path of the labeled node.
>
> + -L
> + Possibly generates a __local_fixups__ and a __fixups__ node at the root node.
> + For each property that contains a phandle reference using a locally
> + defined phandle, the __local_fixups__ node contains a property (at path
> + /__local_fixups__/$a if $a is the path of the node). Its value is a list
> + of offsets that are phandle values. If there are no such properties, no
> + __local_fixups__ node is generated.
> + For each undefined label used in at least one reference, the __fixups__
> + node contains a property. Its name is the label name, its value is a
> + list of locations where the label is used in a reference in the format
> + "path:property:offset". If there is no undefined label, no __fixups__
> + nodes is generated.
> + Enabled by default for compiling overlays (i.e. dts files with a
> + /plugin/ tag).
>
> -A
> Generate automatically aliases for all node labels. This is similar to
> diff --git a/dtc.c b/dtc.c
> index bc786c543b7e..d2e4e2b55b5c 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -47,7 +47,7 @@ static void fill_fullpaths(struct node *tree, const char *prefix)
>
> /* Usage related data. */
> static const char usage_synopsis[] = "dtc [options] <input file>";
> -static const char usage_short_opts[] = "qI:O:o:V:d:R:S:p:a:fb:i:H:sW:E:@AThv";
> +static const char usage_short_opts[] = "qI:O:o:V:d:R:S:p:a:fb:i:H:sW:E:@LAThv";
> static struct option const usage_long_opts[] = {
> {"quiet", no_argument, NULL, 'q'},
> {"in-format", a_argument, NULL, 'I'},
> @@ -67,6 +67,7 @@ static struct option const usage_long_opts[] = {
> {"warning", a_argument, NULL, 'W'},
> {"error", a_argument, NULL, 'E'},
> {"symbols", no_argument, NULL, '@'},
> + {"local-fixups", no_argument, NULL, 'L'},
> {"auto-alias", no_argument, NULL, 'A'},
> {"annotate", no_argument, NULL, 'T'},
> {"help", no_argument, NULL, 'h'},
> @@ -252,6 +253,11 @@ int main(int argc, char *argv[])
> case '@':
> generate_symbols = 1;
> break;
> +
> + case 'L':
> + generate_fixups = 1;
> + break;
> +
> case 'A':
> auto_label_aliases = 1;
> break;
>
> base-commit: 3b02a94b486f998aa22d898b427820a805d0904f
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-05-27 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 8:09 [PATCH v3] dtc: Add an option to generate __local_fixups__ and __fixups__ Uwe Kleine-König
[not found] ` <20230523080941.419330-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2023-05-27 1:54 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHFi7X09bHW4Wts/@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=entwicklung-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).