From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Charles Perry
<charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] dtc: fix missing string in usage_opts_help
Date: Mon, 4 Sep 2023 12:51:18 +1000 [thread overview]
Message-ID: <ZPVGJrsOKaKyOrmu@zatzit> (raw)
In-Reply-To: <20230904020058.1935334-1-charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
On Sun, Sep 03, 2023 at 07:00:57PM -0700, Charles Perry wrote:
> This fixes the output of the `dtc --help` command as the last few
> entries were offset by one.
>
> Signed-off-by: Charles Perry <charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
Good catch, but when I apply this the descriptions still don't line up
with the correct options. I think the new entry has been added in the
wrong order?
> ---
> dtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/dtc.c b/dtc.c
> index d2e4e2b..775d527 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -107,6 +107,7 @@ static const char * const usage_opts_help[] = {
> "\n\tEnable generation of symbols",
> "\n\tEnable auto-alias of labels",
> "\n\tAnnotate output .dts with input source file and line (-T -T for more details)",
> + "\n\tPossibly generates a __local_fixups__ and a __fixups__ node at the root node",
> "\n\tPrint this help and exit",
> "\n\tPrint version and exit",
> NULL,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-04 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 2:00 [PATCH 1/2] dtc: fix missing string in usage_opts_help Charles Perry
[not found] ` <20230904020058.1935334-1-charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2023-09-04 2:00 ` [PATCH 2/2] dtc: ensure that command line options arrays length match Charles Perry
2023-09-04 2:51 ` David Gibson [this message]
2023-09-04 14:20 ` [PATCH 1/2] dtc: fix missing string in usage_opts_help Charles Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPVGJrsOKaKyOrmu@zatzit \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).