From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: case sensitivity for devicetree node names
Date: Tue, 14 Jun 2016 16:05:17 +1000 [thread overview]
Message-ID: <20160614060517.GN4882@voom.fritz.box> (raw)
In-Reply-To: <575F963F.8090105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]
On Mon, Jun 13, 2016 at 10:29:35PM -0700, Frank Rowand wrote:
> On 06/13/16 22:10, David Gibson wrote:
> > On Mon, Jun 13, 2016 at 08:53:37PM -0700, Frank Rowand wrote:
> >> On 06/13/16 18:10, David Gibson wrote:
>
> < snip >
>
> >>> Here's my inclination for how to treat this in dtc for the time being:
> >>> 1) Leave the bulk of dtc case sensitive, as now
> >>> 2) Add a new check which will generate an error if there are node
> >>> names which differ only in case.
> >>>
> >>> Any objections to that plan?
> >>
> >> I think that the kernel should match the current behavior of dtc.
> >>
> >> I agree with "1)".
> >>
> >> I don't think that "2)" is required. I think it is a really dumb idea for
> >> anyone to create a dts with node names that differ only in case. But I
> >> don't think it is the compiler's job to protect people from being dumb.
> >> An analogue would be the C language and compilers. The C compiler doesn't
> >> error on a program that has variables "foo" and "Foo".
> >
> > Hmm.. actually I think protecting you from being dumb is exactly the
> > purpose of compiler warnings. Now that you found that quote from
> > 1275, which is pretty definitive as far as I'm concerned, I'd expect
> > to reduce that error to a warning (by default).
>
> A warning is ok by me.
Ok, I'll implement that when I get a chance.
Note that in most cases there's no fundamental distinction between dtc
errors and dtc warnings - it's just a question of whether they're
flagged as "error" or "warning" level in the check table.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-14 6:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 20:05 case sensitivity for devicetree node names Frank Rowand
[not found] ` <575B1D84.2010703-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-10 21:38 ` Rob Herring
[not found] ` <CAL_JsqKw8dVp5y487fo6_mwZfeN6ww8HiYnsudnB8afBrv2oMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-10 22:02 ` Frank Rowand
2016-06-11 19:38 ` Frank Rowand
[not found] ` <575C68A1.1020701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-11 22:05 ` Benjamin Herrenschmidt
[not found] ` <1465682743.19533.18.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2016-06-12 18:39 ` Frank Rowand
[not found] ` <575DAC69.5010804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-12 21:56 ` Benjamin Herrenschmidt
2016-06-14 1:10 ` David Gibson
[not found] ` <20160614011021.GD4882-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-14 3:53 ` Frank Rowand
[not found] ` <575F7FC1.5040508-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-14 5:10 ` David Gibson
[not found] ` <20160614051028.GL4882-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-14 5:29 ` Frank Rowand
[not found] ` <575F963F.8090105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-14 6:05 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614060517.GN4882@voom.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).