From: Li Lingfeng <lilingfeng3@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <stable@vger.kernel.org>, <mpatocka@redhat.com>,
<torvalds@linux-foundation.org>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <dm-devel@lists.linux.dev>,
<msnitzer@redhat.com>, <ignat@cloudflare.com>,
<damien.lemoal@wdc.com>, <bob.liu@oracle.com>,
<houtao1@huawei.com>, <nhuck@google.com>, <peterz@infradead.org>,
<mingo@elte.hu>, <yukuai3@huawei.com>, <yangerkun@huawei.com>,
<yi.zhang@huawei.com>, <lilingfeng@huaweicloud.com>
Subject: Re: [PATCH 6.6] Revert "dm-crypt, dm-verity: disable tasklets"
Date: Thu, 11 Apr 2024 20:17:53 +0800 [thread overview]
Message-ID: <1f9f1ea8-0a94-4d4c-cae3-983f307e6840@huawei.com> (raw)
In-Reply-To: <2024041103-reputable-bobsled-585f@gregkh>
There is no need to revert it in Linus's tree since the expanded
workqueue can work like tasklet.
https://lore.kernel.org/lkml/20240130091300.2968534-1-tj@kernel.org/
I'm not sure if the problem described in [1] could be triggered by a
scenario I haven't considered. So I only send the revert patch to 6.6
mainly for comments.
Of course, I think the other branches need it too.
Thanks
在 2024/4/11 17:52, Greg KH 写道:
> On Thu, Apr 11, 2024 at 05:15:39PM +0800, Li Lingfeng wrote:
>> This reverts commit 5735a2671ffb70ea29ca83969fe01316ee2ed6fc which is
>> commit 0a9bab391e336489169b95cb0d4553d921302189 upstream.
>>
>> Tasklet is thought to cause memory corruption [1], so it was disabled in
>> dm-crypt and dm-verity. However, memory corruption may not happen since
>> cc->io_queue is created without WQ_UNBOUND [2].
>> Revert commit 5735a2671ffb ("dm-crypt, dm-verity: disable tasklets") to
>> bring tasklet back.
>>
>> [1] https://lore.kernel.org/all/d390d7ee-f142-44d3-822a-87949e14608b@suse.de/T/
>> [2] https://lore.kernel.org/all/4d331659-badd-749d-fba1-271543631a8a@huawei.com/
>>
>> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
>> ---
>> drivers/md/dm-crypt.c | 38 +++++++++++++++++++++++++++++++++--
>> drivers/md/dm-verity-target.c | 26 ++++++++++++++++++++++--
>> drivers/md/dm-verity.h | 1 +
>> 3 files changed, 61 insertions(+), 4 deletions(-)
> What is the commit id of this in Linus's tree? And why only 6.6.y?
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2024-04-11 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 9:15 [PATCH 6.6] Revert "dm-crypt, dm-verity: disable tasklets" Li Lingfeng
2024-04-11 9:52 ` Greg KH
2024-04-11 12:17 ` Li Lingfeng [this message]
2024-04-11 12:37 ` Mikulas Patocka
2024-04-12 2:06 ` Li Lingfeng
2024-04-15 15:04 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f9f1ea8-0a94-4d4c-cae3-983f307e6840@huawei.com \
--to=lilingfeng3@huawei.com \
--cc=bob.liu@oracle.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=houtao1@huawei.com \
--cc=ignat@cloudflare.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=nhuck@google.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).