DM-Devel Archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@lists.linux.dev, Mike Snitzer <snitzer@redhat.com>,
	linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v7 17/28] null_blk: Introduce fua attribute
Date: Mon,  8 Apr 2024 10:41:17 +0900	[thread overview]
Message-ID: <20240408014128.205141-18-dlemoal@kernel.org> (raw)
In-Reply-To: <20240408014128.205141-1-dlemoal@kernel.org>

Add the fua configfs attribute and module parameter to allow
configuring if the device supports FUA or not. Using this attribute
has an effect on the null_blk device only if memory backing is enabled
together with a write cache (cache_size option).

This new attribute allows configuring a null_blk device with a write
cache but without FUA support. This is convenient to test the block
layer flush machinery.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Tested-by: Hans Holmberg <hans.holmberg@wdc.com>
Tested-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/block/null_blk/main.c     | 12 ++++++++++--
 drivers/block/null_blk/null_blk.h |  1 +
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 14e9aa867afe..993e9e8a7e69 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -225,6 +225,10 @@ static unsigned long g_cache_size;
 module_param_named(cache_size, g_cache_size, ulong, 0444);
 MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (none)");
 
+static bool g_fua = true;
+module_param_named(fua, g_fua, bool, 0444);
+MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used. Default: true");
+
 static unsigned int g_mbps;
 module_param_named(mbps, g_mbps, uint, 0444);
 MODULE_PARM_DESC(mbps, "Limit maximum bandwidth (in MiB/s). Default: 0 (no limit)");
@@ -446,6 +450,7 @@ NULLB_DEVICE_ATTR(virt_boundary, bool, NULL);
 NULLB_DEVICE_ATTR(no_sched, bool, NULL);
 NULLB_DEVICE_ATTR(shared_tags, bool, NULL);
 NULLB_DEVICE_ATTR(shared_tag_bitmap, bool, NULL);
+NULLB_DEVICE_ATTR(fua, bool, NULL);
 
 static ssize_t nullb_device_power_show(struct config_item *item, char *page)
 {
@@ -593,6 +598,7 @@ static struct configfs_attribute *nullb_device_attrs[] = {
 	&nullb_device_attr_no_sched,
 	&nullb_device_attr_shared_tags,
 	&nullb_device_attr_shared_tag_bitmap,
+	&nullb_device_attr_fua,
 	NULL,
 };
 
@@ -671,7 +677,7 @@ nullb_group_drop_item(struct config_group *group, struct config_item *item)
 static ssize_t memb_group_features_show(struct config_item *item, char *page)
 {
 	return snprintf(page, PAGE_SIZE,
-			"badblocks,blocking,blocksize,cache_size,"
+			"badblocks,blocking,blocksize,cache_size,fua,"
 			"completion_nsec,discard,home_node,hw_queue_depth,"
 			"irqmode,max_sectors,mbps,memory_backed,no_sched,"
 			"poll_queues,power,queue_mode,shared_tag_bitmap,"
@@ -763,6 +769,8 @@ static struct nullb_device *null_alloc_dev(void)
 	dev->no_sched = g_no_sched;
 	dev->shared_tags = g_shared_tags;
 	dev->shared_tag_bitmap = g_shared_tag_bitmap;
+	dev->fua = g_fua;
+
 	return dev;
 }
 
@@ -1920,7 +1928,7 @@ static int null_add_dev(struct nullb_device *dev)
 
 	if (dev->cache_size > 0) {
 		set_bit(NULLB_DEV_FL_CACHE, &nullb->dev->flags);
-		blk_queue_write_cache(nullb->q, true, true);
+		blk_queue_write_cache(nullb->q, true, dev->fua);
 	}
 
 	nullb->q->queuedata = nullb;
diff --git a/drivers/block/null_blk/null_blk.h b/drivers/block/null_blk/null_blk.h
index a9c5df650ddb..3234e6c85eed 100644
--- a/drivers/block/null_blk/null_blk.h
+++ b/drivers/block/null_blk/null_blk.h
@@ -105,6 +105,7 @@ struct nullb_device {
 	bool no_sched; /* no IO scheduler for the device */
 	bool shared_tags; /* share tag set between devices for blk-mq */
 	bool shared_tag_bitmap; /* use hostwide shared tags */
+	bool fua; /* Support FUA */
 };
 
 struct nullb {
-- 
2.44.0


  parent reply	other threads:[~2024-04-08  1:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  1:41 [PATCH v7 00/28] Zone write plugging Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 01/28] block: Restore sector of flush requests Damien Le Moal
2024-04-08 15:42   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 02/28] block: Remove req_bio_endio() Damien Le Moal
2024-04-08 15:46   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 03/28] block: Introduce blk_zone_update_request_bio() Damien Le Moal
2024-04-08 15:47   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 04/28] block: Introduce bio_straddles_zones() and bio_offset_from_zone_start() Damien Le Moal
2024-04-08 15:50   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 05/28] block: Allow using bio_attempt_back_merge() internally Damien Le Moal
2024-04-08 15:51   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 06/28] block: Remember zone capacity when revalidating zones Damien Le Moal
2024-04-08 15:53   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 07/28] block: Introduce zone write plugging Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 08/28] block: Fake max open zones limit when there is no limit Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 09/28] block: Allow zero value of max_zone_append_sectors queue limit Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 10/28] block: Implement zone append emulation Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 11/28] block: Allow BIO-based drivers to use blk_revalidate_disk_zones() Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 12/28] dm: Use the block layer zone append emulation Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 13/28] scsi: sd: " Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 14/28] ublk_drv: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 15/28] null_blk: " Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 16/28] null_blk: Introduce zone_append_max_sectors attribute Damien Le Moal
2024-04-08  1:41 ` Damien Le Moal [this message]
2024-04-08  1:41 ` [PATCH v7 18/28] nvmet: zns: Do not reference the gendisk conv_zones_bitmap Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 19/28] block: Remove BLK_STS_ZONE_RESOURCE Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 20/28] block: Simplify blk_revalidate_disk_zones() interface Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 21/28] block: mq-deadline: Remove support for zone write locking Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 22/28] block: Remove elevator required features Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 23/28] block: Do not check zone type in blk_check_zone_append() Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 24/28] block: Move zone related debugfs attribute to blk-zoned.c Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 25/28] block: Replace zone_wlock debugfs entry with zone_wplugs entry Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 26/28] block: Remove zone write locking Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 27/28] block: Do not force select mq-deadline with CONFIG_BLK_DEV_ZONED Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 28/28] block: Do not special-case plugging of zone write operations Damien Le Moal
2024-04-08  6:02 ` [PATCH v7 00/28] Zone write plugging Christoph Hellwig
2024-04-12  0:19 ` Damien Le Moal
2024-04-17 14:45 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408014128.205141-18-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).