From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Matthew Sakai <msakai@redhat.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
jack@suse.cz, hch@lst.de, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com,
dm-devel@lists.linux.dev
Subject: Re: [PATCH vfs.all 19/26] dm-vdo: convert to use bdev_file
Date: Thu, 11 Apr 2024 13:12:50 +0200 [thread overview]
Message-ID: <20240411-abwinken-gesehen-a8f038f147aa@brauner> (raw)
In-Reply-To: <20240410174022.GF2118490@ZenIV>
On Wed, Apr 10, 2024 at 06:40:22PM +0100, Al Viro wrote:
> On Wed, Apr 10, 2024 at 01:26:47PM -0400, Matthew Sakai wrote:
>
> > > 'dm_dev->bdev_file', it's ok to get inode from the file.
>
> It can be done much easier, though -
>
> [PATCH] dm-vdo: use bdev_nr_bytes(bdev) instead of i_size_read(bdev->bd_inode)
>
> going to be faster, actually - shift is cheaper than dereference...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
I've used that patch instead of the original one.
prev parent reply other threads:[~2024-04-11 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240406090930.2252838-1-yukuai1@huaweicloud.com>
[not found] ` <20240406090930.2252838-20-yukuai1@huaweicloud.com>
2024-04-10 17:26 ` [PATCH vfs.all 19/26] dm-vdo: convert to use bdev_file Matthew Sakai
2024-04-10 17:40 ` Al Viro
2024-04-10 18:59 ` Matthew Sakai
2024-04-11 11:12 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411-abwinken-gesehen-a8f038f147aa@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=msakai@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).