From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
dm-devel@lists.linux.dev, Mike Snitzer <snitzer@redhat.com>
Subject: [PATCH v2 01/14] dm: Check that a zoned table leads to a valid mapped device
Date: Wed, 1 May 2024 09:09:22 +0900 [thread overview]
Message-ID: <20240501000935.100534-2-dlemoal@kernel.org> (raw)
In-Reply-To: <20240501000935.100534-1-dlemoal@kernel.org>
Using targets such as dm-linear, a mapped device can be created to
contain only conventional zones. Such device should not be treated as
zoned as it does not contain any mandatory sequential write required
zone. Since such device can be randomly written, we can modify
dm_set_zones_restrictions() to set the mapped device zoned queue limit
to false to expose it as a regular block device. The function
dm_check_zoned() does this after counting the number of conventional
zones of the mapped device and comparing it to the total number of zones
reported. The special dm_check_zoned_cb() report zones callback function
is used to count conventional zones.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/md/dm-table.c | 3 ++-
drivers/md/dm-zone.c | 53 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 41f1d731ae5a..2c6fbd87363f 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -2042,7 +2042,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
r = dm_set_zones_restrictions(t, q);
if (r)
return r;
- if (!static_key_enabled(&zoned_enabled.key))
+ if (blk_queue_is_zoned(q) &&
+ !static_key_enabled(&zoned_enabled.key))
static_branch_enable(&zoned_enabled);
}
diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c
index d17ae4486a6a..3071f67d72aa 100644
--- a/drivers/md/dm-zone.c
+++ b/drivers/md/dm-zone.c
@@ -145,6 +145,48 @@ bool dm_is_zone_write(struct mapped_device *md, struct bio *bio)
}
}
+/*
+ * Count conventional zones of a mapped zoned device. If the device
+ * only has conventional zones, do not expose it as zoned.
+ */
+static int dm_check_zoned_cb(struct blk_zone *zone, unsigned int idx,
+ void *data)
+{
+ unsigned int *nr_conv_zones = data;
+
+ if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
+ (*nr_conv_zones)++;
+
+ return 0;
+}
+
+static int dm_check_zoned(struct mapped_device *md, struct dm_table *t)
+{
+ struct gendisk *disk = md->disk;
+ unsigned int nr_conv_zones = 0;
+ int ret;
+
+ /* Revalidate only if something changed. */
+ md->zone_revalidate_map = t;
+ ret = dm_blk_report_zones(disk, 0, UINT_MAX,
+ dm_check_zoned_cb, &nr_conv_zones);
+ md->zone_revalidate_map = NULL;
+ if (ret < 0) {
+ DMERR("Check zoned failed %d", ret);
+ return ret;
+ }
+
+ if (nr_conv_zones >= ret) {
+ disk->queue->limits.max_open_zones = 0;
+ disk->queue->limits.max_active_zones = 0;
+ disk->queue->limits.zoned = false;
+ clear_bit(DMF_EMULATE_ZONE_APPEND, &md->flags);
+ disk->nr_zones = 0;
+ }
+
+ return 0;
+}
+
/*
* Revalidate the zones of a mapped device to initialize resource necessary
* for zone append emulation. Note that we cannot simply use the block layer
@@ -208,6 +250,7 @@ static bool dm_table_supports_zone_append(struct dm_table *t)
int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q)
{
struct mapped_device *md = t->md;
+ int ret;
/*
* Check if zone append is natively supported, and if not, set the
@@ -224,6 +267,16 @@ int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q)
if (!get_capacity(md->disk))
return 0;
+ /*
+ * Check that the mapped device will indeed be zoned, that is, that it
+ * has sequential write required zones.
+ */
+ ret = dm_check_zoned(md, t);
+ if (ret)
+ return ret;
+ if (!blk_queue_is_zoned(q))
+ return 0;
+
if (!md->disk->nr_zones) {
DMINFO("%s using %s zone append",
md->disk->disk_name,
--
2.44.0
next prev parent reply other threads:[~2024-05-01 0:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 0:09 [PATCH v2 00/14] Zone write plugging fixes and cleanup Damien Le Moal
2024-05-01 0:09 ` Damien Le Moal [this message]
2024-05-01 3:07 ` [PATCH v2 01/14] dm: Check that a zoned table leads to a valid mapped device Benjamin Marzinski
2024-05-01 9:14 ` Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 02/14] block: Exclude conventional zones when faking max open limit Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 03/14] block: Fix zone write plug initialization from blk_revalidate_zone_cb() Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 04/14] block: Fix reference counting for zone write plugs in error state Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 05/14] block: Hold a reference on zone write plugs to schedule submission Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 06/14] block: Unhash a zone write plug only if needed Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 07/14] block: Do not remove zone write plugs still in use Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 08/14] block: Fix flush request sector restore Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 09/14] block: Fix handling of non-empty flush write requests to zones Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 10/14] block: Improve blk_zone_write_plug_bio_merged() Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 11/14] block: Improve zone write request completion handling Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 12/14] block: Simplify blk_zone_write_plug_bio_endio() Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 13/14] block: Simplify zone write plug BIO abort Damien Le Moal
2024-05-01 0:09 ` [PATCH v2 14/14] block: Cleanup blk_revalidate_zone_cb() Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501000935.100534-2-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).