From: Martin Wilck <martin.wilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@lists.linux.dev>
Subject: Re: [PATCH 1/3] libmultipath: export partmap_in_use and do_deferred
Date: Wed, 24 Apr 2024 18:40:58 +0200 [thread overview]
Message-ID: <5fd325ecb0f2ee6c843b70aa33fb2b7c9ad07554.camel@suse.com> (raw)
In-Reply-To: <20240423222536.2096486-2-bmarzins@redhat.com>
On Tue, 2024-04-23 at 18:25 -0400, Benjamin Marzinski wrote:
> A future commit will make use of these functions
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/devmapper.c | 4 +---
> libmultipath/devmapper.h | 3 +++
> libmultipath/libmultipath.version | 1 +
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
> index 4ce7e82f..24d03e83 100644
> --- a/libmultipath/devmapper.c
> +++ b/libmultipath/devmapper.c
> @@ -386,8 +386,6 @@ libmp_dm_task_create(int task)
> return dm_task_create(task);
> }
>
> -#define do_deferred(x) ((x) == DEFERRED_REMOVE_ON || (x) ==
> DEFERRED_REMOVE_IN_PROGRESS)
> -
> static int
> dm_simplecmd (int task, const char *name, int no_flush, int
> need_sync,
> uint16_t udev_flags, int deferred_remove
> __DR_UNUSED__) {
> @@ -1043,7 +1041,7 @@ has_partmap(const char *name
> __attribute__((unused)),
> return 1;
> }
>
> -static int
> +int
> partmap_in_use(const char *name, void *data)
> {
> int part_count, *ret_count = (int *)data;
> diff --git a/libmultipath/devmapper.h b/libmultipath/devmapper.h
> index a7d66604..2987a1b5 100644
> --- a/libmultipath/devmapper.h
> +++ b/libmultipath/devmapper.h
> @@ -57,6 +57,9 @@ enum {
> DM_FLUSH_BUSY,
> };
>
> +#define do_deferred(x) ((x) == DEFERRED_REMOVE_ON || (x) ==
> DEFERRED_REMOVE_IN_PROGRESS)
> +
> +int partmap_in_use(const char *name, void *data);
> int _dm_flush_map (const char *, int, int, int, int);
> int dm_flush_map_nopaths(const char * mapname, int deferred_remove);
> #define dm_flush_map(mapname) _dm_flush_map(mapname, 1, 0, 0, 0)
> diff --git a/libmultipath/libmultipath.version
> b/libmultipath/libmultipath.version
> index 724786d5..e070f296 100644
> --- a/libmultipath/libmultipath.version
> +++ b/libmultipath/libmultipath.version
> @@ -141,6 +141,7 @@ global:
> need_io_err_check;
> orphan_path;
> parse_prkey_flags;
> + partmap_in_use;
> pathcount;
> path_discovery;
> path_get_tpgs;
next prev parent reply other threads:[~2024-04-24 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 22:25 [PATCH 0/3] multipath: fix hang in flush_map_nopaths Benjamin Marzinski
2024-04-23 22:25 ` [PATCH 1/3] libmultipath: export partmap_in_use and do_deferred Benjamin Marzinski
2024-04-24 16:40 ` Martin Wilck [this message]
2024-05-02 15:06 ` Martin Wilck
2024-04-23 22:25 ` [PATCH 2/3] libmultipath: change flush_on_last_del to fix a multipathd hang Benjamin Marzinski
2024-04-24 16:34 ` Martin Wilck
2024-04-24 20:42 ` Benjamin Marzinski
2024-04-24 22:15 ` Benjamin Marzinski
2024-04-25 16:56 ` Martin Wilck
2024-04-23 22:25 ` [PATCH 3/3] libmultipath: simplify dm_flush_map_nopaths Benjamin Marzinski
2024-04-24 16:40 ` Martin Wilck
2024-04-24 20:43 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd325ecb0f2ee6c843b70aa33fb2b7c9ad07554.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).