DM-Devel Archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>,
	Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@lists.linux.dev>
Subject: Re: [PATCH v2] multipathd: Set CPUWeight to 1000 and LimitRTPRIO to 10
Date: Tue, 16 Apr 2024 11:59:43 +0200	[thread overview]
Message-ID: <79596769d7ebe048cbfe95020f5c492a12bb1673.camel@suse.com> (raw)
In-Reply-To: <20240415234306.1984762-1-bmarzins@redhat.com>

On Mon, 2024-04-15 at 19:43 -0400, Benjamin Marzinski wrote:
> If multipathd doesn't become a real time process, it was scheduled as
> a
> normal process, without any priority increase. Bump up the CPUWeight
> so
> that even as a normal process, it will still run with increased
> priority.
> 
> If multipathd did become a real time process, it set itself to the
> highest priority, which is excessive. A priority of 10 is plenty.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

> ---
> 
> Notes:
>     v2: Lowered LimitRTPRIO as suggested by Martin Wilck.
> 
>  multipathd/multipathd.service.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/multipathd/multipathd.service.in
> b/multipathd/multipathd.service.in
> index 18bb367e..a63ddd9a 100644
> --- a/multipathd/multipathd.service.in
> +++ b/multipathd/multipathd.service.in
> @@ -19,7 +19,8 @@ NotifyAccess=main
>  ExecStart=/sbin/multipathd -d -s
>  ExecReload=/sbin/multipathd reconfigure
>  TasksMax=infinity
> -LimitRTPRIO=infinity
> +LimitRTPRIO=10
> +CPUWeight=1000
>  
>  [Install]
>  WantedBy=sysinit.target


      reply	other threads:[~2024-04-16  9:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 23:43 [PATCH v2] multipathd: Set CPUWeight to 1000 and LimitRTPRIO to 10 Benjamin Marzinski
2024-04-16  9:59 ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79596769d7ebe048cbfe95020f5c492a12bb1673.camel@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).