From: Mikulas Patocka <mpatocka@redhat.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Mike Snitzer <msnitzer@redhat.com>,
Guangwu Zhang <guazhang@redhat.com>,
dm-devel@lists.linux.dev
Subject: Re: [PATCH v2] dm-io: don't warn if flush takes too long time
Date: Wed, 17 Apr 2024 11:07:29 +0200 (CEST) [thread overview]
Message-ID: <7efe37a2-a1bc-99e-60ff-a93a1ea77919@redhat.com> (raw)
In-Reply-To: <c5e8c781-24e6-4f06-8a97-7667e888aa82@kernel.org>
On Wed, 17 Apr 2024, Damien Le Moal wrote:
> On 2024/04/16 0:23, Mikulas Patocka wrote:
> >>> @@ -119,4 +120,16 @@ extern void complete(struct completion *
> >>> extern void complete_on_current_cpu(struct completion *x);
> >>> extern void complete_all(struct completion *);
> >>>
> >>> +static inline void blk_wait_io(struct completion *done)
> >>
> >> Since you move this function outside of the block layer, the "blk_" prefix seems
> >> out of place. What about renaming this to something like
> >> "wait_for_completion_blk_io()", or to make it clear that it is not the same as
> >> wait_for_completion_io(), may be "wait_for_completion_long_io()" ?
> >
> > Yes. Here I'm sending a second patch that renames this function to
> > wait_for_completion_long_io.
>
> This looks good to me, but you sent this new version as a reply. Please post a
> properly formatted new patch. And since you are touching the block layer, this
> needs to be sent to linux-block and Jens as well.
OK. I've resent it.
Mikulas
prev parent reply other threads:[~2024-04-17 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:46 [PATCH] dm-io: don't warn if flush takes too long time Mikulas Patocka
2024-04-13 0:51 ` Damien Le Moal
2024-04-15 14:23 ` [PATCH v2] " Mikulas Patocka
2024-04-16 23:01 ` Damien Le Moal
2024-04-17 9:07 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7efe37a2-a1bc-99e-60ff-a93a1ea77919@redhat.com \
--to=mpatocka@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=guazhang@redhat.com \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).