From: Changhui Zhong <czhong@redhat.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: ming.lei@redhat.com, brauner@kernel.org,
dm-devel@lists.linux.dev, jack@suse.cz,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] dm: restore synchronous close of device mapper block device
Date: Thu, 18 Apr 2024 10:31:19 +0800 [thread overview]
Message-ID: <CAGVVp+XDaZFEfhVz0XEN4oYQyN6W9_eX9H_E_1nshnsaweED2g@mail.gmail.com> (raw)
In-Reply-To: <20240416152842.13933-1-snitzer@kernel.org>
On Tue, Apr 16, 2024 at 11:29 PM Mike Snitzer <snitzer@kernel.org> wrote:
>
> From: Ming Lei <ming.lei@redhat.com>
>
> 'dmsetup remove' and 'dmsetup remove_all' require synchronous bdev
> release. Otherwise dm_lock_for_deletion() may return -EBUSY if the open
> count is > 0, because the open count is dropped in dm_blk_close()
> which occurs after fput() completes.
>
> So if dm_blk_close() is delayed because of asynchronous fput(), this
> device mapper device is skipped during remove, which is a regression.
>
> Fix the issue by using __fput_sync().
>
> Also: DM device removal has long supported being made asynchronous by
> setting the DMF_DEFERRED_REMOVE flag on the DM device. So leverage
> using async fput() in close_table_device() if DMF_DEFERRED_REMOVE flag
> is set.
>
> Reported-by: Zhong Changhui <czhong@redhat.com>
> Fixes: a28d893eb327 ("md: port block device access to file")
> Suggested-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> [snitzer: editted commit header, use fput() if DMF_DEFERRED_REMOVE set]
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> ---
> drivers/md/dm.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 56aa2a8b9d71..7d0746b37c8e 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -765,7 +765,7 @@ static struct table_device *open_table_device(struct mapped_device *md,
> return td;
>
> out_blkdev_put:
> - fput(bdev_file);
> + __fput_sync(bdev_file);
> out_free_td:
> kfree(td);
> return ERR_PTR(r);
> @@ -778,7 +778,13 @@ static void close_table_device(struct table_device *td, struct mapped_device *md
> {
> if (md->disk->slave_dir)
> bd_unlink_disk_holder(td->dm_dev.bdev, md->disk);
> - fput(td->dm_dev.bdev_file);
> +
> + /* Leverage async fput() if DMF_DEFERRED_REMOVE set */
> + if (unlikely(test_bit(DMF_DEFERRED_REMOVE, &md->flags)))
> + fput(td->dm_dev.bdev_file);
> + else
> + __fput_sync(td->dm_dev.bdev_file);
> +
> put_dax(td->dm_dev.dax_dev);
> list_del(&td->list);
> kfree(td);
> --
> 2.40.0
>
I tried to apply this patch and looks this issue has solved by this patch
prev parent reply other threads:[~2024-04-18 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 0:56 [PATCH] dm: core: put device mapper block device synchronously Ming Lei
2024-04-16 15:28 ` [PATCH v2] dm: restore synchronous close of device mapper block device Mike Snitzer
2024-04-17 1:32 ` Ming Lei
2024-04-17 3:27 ` Mike Snitzer
2024-04-18 2:31 ` Changhui Zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGVVp+XDaZFEfhVz0XEN4oYQyN6W9_eX9H_E_1nshnsaweED2g@mail.gmail.com \
--to=czhong@redhat.com \
--cc=brauner@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).