From: Xiao Ni <xni@redhat.com>
To: Song Liu <song@kernel.org>
Cc: yukuai1@huaweicloud.com, bmarzins@redhat.com, heinzm@redhat.com,
snitzer@kernel.org, ncroxon@redhat.com,
linux-raid@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCH V2 0/4] Fix dmraid regression bugs
Date: Sat, 2 Mar 2024 08:41:50 +0800 [thread overview]
Message-ID: <CALTww29CwWtP5_jBJANGZyAAQw05g=ak6Cu5m+V8p=cJb4MgkA@mail.gmail.com> (raw)
In-Reply-To: <CAPhsuW6ywzQ9oXUHt=2MN6kngWCvtGxOPffnzV=OHDs_01RGLg@mail.gmail.com>
On Sat, Mar 2, 2024 at 6:28 AM Song Liu <song@kernel.org> wrote:
>
> On Fri, Mar 1, 2024 at 7:21 AM Xiao Ni <xni@redhat.com> wrote:
> >
> > Hi all
> >
> > This patch set tries to fix dmraid regression problems we face
> > recently. This patch is based on song's md-6.8 branch.
> >
> > This patch set has four patches. The first two patches revert two patches.
> > The third one and the fourth one resolve deadlock problems.
> >
> > I have run lvm2 regression test 5 times. There are 4 failed cases:
> > shell/dmsetup-integrity-keys.sh
> > shell/lvresize-fs-crypt.sh
> > shell/pvck-dump.sh
> > shell/select-report.sh
> >
> > And lvconvert-raid-reshape.sh can fail sometimes. But it fails in 6.6
> > kernel too. So it can return back to the same state with 6.6 kernel.
> >
> > V2:
> > It doesn't revert commit 82ec0ae59d02
> > ("md: Make sure md_do_sync() will set MD_RECOVERY_DONE")
> > It doesn't clear MD_RECOVERY_WAIT before stopping dmraid
> > Re-write patch01 comment
>
> Unfortunately, I am still seeing the same deadlock in the reboot tests
> with two arrays. OTOH, Yu Kuai's version doesn't have this issue.
> I think we will ship that patch set.
>
> Thanks for your kind work on this issue.
> Song
>
It's a process for me to study :)
I'll have a test based on Yu Kuai's patch set and give the result later.
Best Regards
Xiao
prev parent reply other threads:[~2024-03-02 0:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:21 [PATCH V2 0/4] Fix dmraid regression bugs Xiao Ni
2024-03-01 15:21 ` [PATCH 1/4] md: Revert "md: Don't register sync_thread for reshape directly" Xiao Ni
2024-03-01 15:21 ` [PATCH 2/4] md: Revert "md: Don't ignore suspended array in md_check_recovery()" Xiao Ni
2024-03-01 15:21 ` [PATCH 3/4] md: Set MD_RECOVERY_FROZEN before stop sync thread Xiao Ni
2024-03-01 15:21 ` [PATCH 4/4] md/raid5: Don't check crossing reshape when reshape hasn't started Xiao Ni
2024-03-01 22:28 ` [PATCH V2 0/4] Fix dmraid regression bugs Song Liu
2024-03-02 0:41 ` Xiao Ni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALTww29CwWtP5_jBJANGZyAAQw05g=ak6Cu5m+V8p=cJb4MgkA@mail.gmail.com' \
--to=xni@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=heinzm@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).