From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev, Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH 0/3] libmultipath: use bitwise flags in devmapper API
Date: Fri, 3 May 2024 12:08:20 -0400 [thread overview]
Message-ID: <ZjUL9Ih86_7oCcHj@redhat.com> (raw)
In-Reply-To: <20240502185946.31192-1-mwilck@suse.com>
On Thu, May 02, 2024 at 08:59:43PM +0200, Martin Wilck wrote:
> This series goes on top of Benjamin Marzinksi's late "multipath: fix hang
> in flush_map_nopaths" series. It introduces no functional changes. It
> just combines the multiple boolean arguments to _dm_flush_map() and
> dm_simplecmd() into a flags variable. This reduces the number of
> function arguments, but that's not the main intention. The symbolic
> flags improve the readability of the code by making it obvious which
> flags are passed to the respective functions in their callers.
Nice cleanup. For the set:
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Martin Wilck (3):
> libmultipath: use bitwise flags for map flushing API
> libmultipath: use bitwise flags for dm_simplecmd API
> libmultipath: add argument names to some prototypes
>
> libmultipath/devmapper.c | 94 ++++++++++++++++++----------------------
> libmultipath/devmapper.h | 33 +++++++++-----
> 2 files changed, 62 insertions(+), 65 deletions(-)
>
> --
> 2.44.0
prev parent reply other threads:[~2024-05-03 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 18:59 [PATCH 0/3] libmultipath: use bitwise flags in devmapper API Martin Wilck
2024-05-02 18:59 ` [PATCH 1/3] libmultipath: use bitwise flags for map flushing API Martin Wilck
2024-05-02 18:59 ` [PATCH 2/3] libmultipath: use bitwise flags for dm_simplecmd API Martin Wilck
2024-05-02 18:59 ` [PATCH 3/3] libmultipath: add argument names to some prototypes Martin Wilck
2024-05-03 16:08 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjUL9Ih86_7oCcHj@redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).