From: Peter Rajnoha <prajnoha@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>,
Zdenek Kabelac <zkabelac@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
David Teigland <teigland@redhat.com>
Cc: linux-lvm@lists.linux.dev, dm-devel@lists.linux.dev,
Martin Wilck <mwilck@suse.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 0/7] device mapper udev rules rework
Date: Tue, 5 Mar 2024 15:42:24 +0100 [thread overview]
Message-ID: <b605f50c-700a-40a7-b8a0-f5c05400161c@redhat.com> (raw)
In-Reply-To: <20240305120550.11617-1-mwilck@suse.com>
On 3/5/24 13:05, Martin Wilck wrote:
> Martin Wilck (7):
> 13-dm-disk.rules: import ID_FS_TYPE
> 10-dm.rules: test DISK_RO after importing properties
> 10-dm-rules: don't restore DM_UDEV_DISABLE_OTHER_RULES_FLAG from db
> 11-dm-lvm.rules: don't restore DM_UDEV_DISABLE_OTHER_RULES_FLAG from
> db
> dm udev rules: don't export and save DM_SUSPENDED
> dm udev rules: don't export and save DM_NOSCAN
> 10-dm.rules: bump DM_UDEV_RULES_VSN to 3
>
> udev/10-dm.rules.in | 43 +++++++++++++++++++++++++++---------
> udev/11-dm-lvm.rules.in | 13 +++++------
> udev/12-dm-permissions.rules | 2 +-
> udev/13-dm-disk.rules.in | 9 ++++----
> 4 files changed, 43 insertions(+), 24 deletions(-)
>
Only really minor and cosmetic things:
- we're using $env instead of %E to reference the variables,
- maybe let's dump the mention about DM_SUSPENDED in
12-dm-permissions.rules if we're at it
But functionality-wise looks good as already discussed in the RFC
version of the patchset. Thank you!
(You can also create an MR in lvm2's gitlab upstream repo
https://gitlab.com/lvmteam/lvm2 if you have an account there.)
For the whole patchset:
Reviewed-by: Peter Rajnoha <prajnoha@redhat.com>
--
Peter
next prev parent reply other threads:[~2024-03-05 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:05 [PATCH v2 0/7] device mapper udev rules rework Martin Wilck
2024-03-05 12:05 ` [PATCH v2 1/7] 13-dm-disk.rules: import ID_FS_TYPE Martin Wilck
2024-03-05 12:05 ` [PATCH v2 2/7] 10-dm.rules: test DISK_RO after importing properties Martin Wilck
2024-03-05 12:05 ` [PATCH v2 3/7] 10-dm-rules: don't restore DM_UDEV_DISABLE_OTHER_RULES_FLAG from db Martin Wilck
2024-03-05 12:05 ` [PATCH v2 4/7] 11-dm-lvm.rules: " Martin Wilck
2024-03-05 12:05 ` [PATCH v2 5/7] dm udev rules: don't export and save DM_SUSPENDED Martin Wilck
2024-03-05 12:05 ` [PATCH v2 6/7] dm udev rules: don't export and save DM_NOSCAN Martin Wilck
2024-03-05 12:05 ` [PATCH v2 7/7] 10-dm.rules: bump DM_UDEV_RULES_VSN to 3 Martin Wilck
2024-03-05 14:42 ` Peter Rajnoha [this message]
2024-03-05 21:17 ` [PATCH v2 0/7] device mapper udev rules rework Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b605f50c-700a-40a7-b8a0-f5c05400161c@redhat.com \
--to=prajnoha@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.de \
--cc=linux-lvm@lists.linux.dev \
--cc=martin.wilck@suse.com \
--cc=mwilck@suse.com \
--cc=teigland@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).