From: Mikulas Patocka <mpatocka@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Mike Snitzer <msnitzer@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
Guangwu Zhang <guazhang@redhat.com>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] dm-io: don't warn if flush takes too long time
Date: Wed, 17 Apr 2024 18:31:22 +0200 (CEST) [thread overview]
Message-ID: <cb981b28-40c9-d175-ad13-4bee1a1422eb@redhat.com> (raw)
In-Reply-To: <e86c972f-4acc-4b89-9872-b5f92606cfd9@kernel.dk>
On Wed, 17 Apr 2024, Jens Axboe wrote:
> On 4/17/24 3:05 AM, Mikulas Patocka wrote:
> > There was reported hang warning when using dm-integrity on the top of loop
> > device on XFS on a rotational disk. The warning was triggered because
> > flush on the loop device was too slow.
> >
> > There's no easy way to reduce the latency, so I made a patch that shuts
> > the warning up.
> >
> > There's already a function blk_wait_io that avoids the hung task warning.
> > This commit moves this function from block/blk.h to
> > include/linux/completion.h, renames it to wait_for_completion_long_io
> > (because it is not dependent on the block layer at all) and uses it in
> > dm-io instead of wait_for_completion_io.
>
> Change looks fine to me, but while at it, let's just move it into
> blk-core.c and make it public, no need for this function to be a static
> inline.
>
> --
> Jens Axboe
I think we should move it to ./kernel/sched/completion.c. Because the
function has no dependency on the block layer.
I'll send a patch that does it.
Mikulas
next prev parent reply other threads:[~2024-04-17 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 9:05 [PATCH v3] dm-io: don't warn if flush takes too long time Mikulas Patocka
2024-04-17 14:20 ` Jens Axboe
2024-04-17 16:31 ` Mikulas Patocka [this message]
2024-04-17 14:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb981b28-40c9-d175-ad13-4bee1a1422eb@redhat.com \
--to=mpatocka@redhat.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=guazhang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).