From: Kanchan Joshi <joshi.k@samsung.com>
To: Mikulas Patocka <mpatocka@redhat.com>,
Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
Mike Snitzer <snitzer@kernel.org>
Cc: linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] block: change rq_integrity_vec to respect the iterator
Date: Thu, 2 May 2024 16:55:51 +0530 [thread overview]
Message-ID: <cf433030-2cab-9301-7c8e-adef13efba66@samsung.com> (raw)
In-Reply-To: <19d1b52a-f43e-5b41-ff1d-5257c7b3492@redhat.com>
Hi Mikulas
On 4/30/2024 12:07 AM, Mikulas Patocka wrote:
> Hi
>
> I am changing dm-crypt, so that it can store the autenticated encryption
> tag directly into the NVMe metadata (without using dm-integrity). This
> will improve performance significantly, because we can avoid journaling
> done by dm-integrity. I've got it working, but I've found this bug, so I'm
> sending a patch for it.
As noted by others, there are couple of options to have this settled:
- I can borrow stuff from your commit description to patch #5 [1] and
send that out separately
- Or you can add the changes that Anuj pointed and roll out v2
- Or you can take the route suggested by Christoph
Please choose.
[1]
https://lore.kernel.org/linux-nvme/20240425183943.6319-6-joshi.k@samsung.com/
prev parent reply other threads:[~2024-05-02 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240429183739epcas5p1181a2946641784305b188f320033c637@epcas5p1.samsung.com>
2024-04-29 18:37 ` [PATCH] block: change rq_integrity_vec to respect the iterator Mikulas Patocka
2024-04-30 4:49 ` Anuj gupta
2024-04-30 8:16 ` Keith Busch
2024-05-01 7:49 ` Christoph Hellwig
2024-05-02 11:25 ` Kanchan Joshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf433030-2cab-9301-7c8e-adef13efba66@samsung.com \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).