From: Vinod Koul <vkoul@kernel.org>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: nikita.shubin@maquefel.me, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 09/38] dma: cirrus: Convert to DT for Cirrus EP93xx
Date: Thu, 28 Mar 2024 12:57:44 +0530 [thread overview]
Message-ID: <ZgUb8JKn3nXmhkGn@matsya> (raw)
In-Reply-To: <d620c37f58b303260096f73e04dfff6bb65ed1ef.camel@gmail.com>
On 28-03-24, 08:21, Alexander Sverdlin wrote:
> Hello Vinod!
>
> On Thu, 2024-03-28 at 10:01 +0530, Vinod Koul wrote:
> > On 26-03-24, 12:18, Nikita Shubin via B4 Relay wrote:
> > > From: Nikita Shubin <nikita.shubin@maquefel.me>
> > >
> > > Convert Cirrus EP93xx DMA to device tree usage:
> >
> > Subsytem is dmaengine: pls fix that
> >
> > >
> > > - add OF ID match table with data
> > > - add of_probe for device tree
> > > - add xlate for m2m/m2p
> > > - drop subsys_initcall code
> > > - drop platform probe
> > > - drop platform structs usage
> > >
> > > > From now on it only supports device tree probing.
> > >
> > > Co-developed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > > ---
> > > drivers/dma/ep93xx_dma.c | 239 ++++++++++++++++++++++++-------
> > > include/linux/platform_data/dma-ep93xx.h | 6 +
> > > 2 files changed, 191 insertions(+), 54 deletions(-)
> > >
> > > diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> > > index d6c60635e90d..17c8e2badee2 100644
> > > --- a/drivers/dma/ep93xx_dma.c
> > > +++ b/drivers/dma/ep93xx_dma.c
>
> [...]
>
> > >
> > > @@ -104,6 +106,11 @@
> > > #define DMA_MAX_CHAN_BYTES 0xffff
> > > #define DMA_MAX_CHAN_DESCRIPTORS 32
> > >
> > > +enum ep93xx_dma_type {
> > > + M2P_DMA,
> >
> > Is this missing P2M?
>
> Not really. It's not the most obvious one, but anyway a way to enumerate
> two types of DMA engines:
>
> "7.1.1 DMA Features List
> DMA specific features are:
> • Ten fully independent, programmable DMA controller internal M2P/P2M
> channels (5 Tx and 5 Rx).
> • Two dedicated channels for Memory-to-Memory (M2M) and
> Memory-to-External Peripheral Transfers (external M2P/P2M)."
>
> Now the confusing part is that this "M2M" engine is actually used
> to transfer to and from *some* devices, like SPI and IDE.
> So both engines are capable of M2P and P2M, maybe Cirrus has named
> two engines in a sub-optimal way decades ago and this is now a bit
> historical naming.
Okay, thanks for clarifying (might be worthwhile to mention this in
comments)
--
~Vinod
next prev parent reply other threads:[~2024-03-28 7:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:18 [PATCH v9 00/38] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-03-26 9:18 ` [PATCH v9 08/38] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-03-28 4:26 ` Vinod Koul
2024-03-26 9:18 ` [PATCH v9 09/38] dma: cirrus: Convert to DT for " Nikita Shubin via B4 Relay
2024-03-28 4:31 ` Vinod Koul
2024-03-28 7:21 ` Alexander Sverdlin
2024-03-28 7:27 ` Vinod Koul [this message]
2024-03-28 7:24 ` Nikita Shubin
2024-03-28 7:28 ` Vinod Koul
2024-03-26 9:19 ` [PATCH v9 38/38] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2024-03-28 4:44 ` Vinod Koul
2024-03-28 6:59 ` Alexander Sverdlin
2024-03-26 10:07 ` [PATCH v9 00/38] ep93xx device tree conversion Arnd Bergmann
2024-04-13 8:48 ` Uwe Kleine-König
2024-03-26 10:19 ` Krzysztof Kozlowski
2024-03-26 14:49 ` Andy Shevchenko
2024-03-27 5:07 ` Krzysztof Kozlowski
2024-03-27 10:59 ` Andy Shevchenko
2024-03-26 14:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgUb8JKn3nXmhkGn@matsya \
--to=vkoul@kernel.org \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).