From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Vinod Koul <vkoul@kernel.org>, nikita.shubin@maquefel.me
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 38/38] dma: cirrus: remove platform code
Date: Thu, 28 Mar 2024 07:59:46 +0100 [thread overview]
Message-ID: <ce28c856695f895a1fba8d28c656647eb3f67d2d.camel@gmail.com> (raw)
In-Reply-To: <ZgT1lkJYP-beY_i0@matsya>
Hi Vinod!
On Thu, 2024-03-28 at 10:14 +0530, Vinod Koul wrote:
> > From: Nikita Shubin <nikita.shubin@maquefel.me>
>
> s/dma/dmaengine is subject line
>
> >
> > Remove DMA platform header, from now on we use device tree for DMA
> > clients.
> >
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> > drivers/dma/ep93xx_dma.c | 48 ++++++++++++++-
> > include/linux/platform_data/dma-ep93xx.h | 100 -------------------------------
> > 2 files changed, 46 insertions(+), 102 deletions(-)
> >
> > diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> > index 17c8e2badee2..43c4241af7f5 100644
> > --- a/drivers/dma/ep93xx_dma.c
> > +++ b/drivers/dma/ep93xx_dma.c
[...]
> > +/*
> > + * ep93xx_dma_chan_direction - returns direction the channel can be used
> > + *
> > + * This function can be used in filter functions to find out whether the
> > + * channel supports given DMA direction. Only M2P channels have such
> > + * limitation, for M2M channels the direction is configurable.
> > + */
> > +static inline enum dma_transfer_direction
> > +ep93xx_dma_chan_direction(struct dma_chan *chan)
> > +{
> > + if (!ep93xx_dma_chan_is_m2p(chan))
> > + return DMA_TRANS_NONE;
> > +
> > + /* even channels are for TX, odd for RX */
>
> Is this a SW limitation and HW one?
The numbering scheme is defined in HW:
https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf
"7.2.2 Internal M2P/P2M Channel Register Map" -> "PPALLOC"
"NOTE: The naming convention used for channels and
ports is as follows - even numbers correspond to transmit
channels/ports and odd numbers correspond to receive
channels/ports."
> > + return (chan->chan_id % 2 == 0) ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
> > +}
--
Alexander Sverdlin.
next prev parent reply other threads:[~2024-03-28 7:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:18 [PATCH v9 00/38] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-03-26 9:18 ` [PATCH v9 08/38] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-03-28 4:26 ` Vinod Koul
2024-03-26 9:18 ` [PATCH v9 09/38] dma: cirrus: Convert to DT for " Nikita Shubin via B4 Relay
2024-03-28 4:31 ` Vinod Koul
2024-03-28 7:21 ` Alexander Sverdlin
2024-03-28 7:27 ` Vinod Koul
2024-03-28 7:24 ` Nikita Shubin
2024-03-28 7:28 ` Vinod Koul
2024-03-26 9:19 ` [PATCH v9 38/38] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2024-03-28 4:44 ` Vinod Koul
2024-03-28 6:59 ` Alexander Sverdlin [this message]
2024-03-26 10:07 ` [PATCH v9 00/38] ep93xx device tree conversion Arnd Bergmann
2024-04-13 8:48 ` Uwe Kleine-König
2024-03-26 10:19 ` Krzysztof Kozlowski
2024-03-26 14:49 ` Andy Shevchenko
2024-03-27 5:07 ` Krzysztof Kozlowski
2024-03-27 10:59 ` Andy Shevchenko
2024-03-26 14:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce28c856695f895a1fba8d28c656647eb3f67d2d.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).