From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
david.marchand@redhat.com, aman.deep.singh@intel.com,
yuying.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction
Date: Fri, 19 Apr 2024 12:30:24 +0100 [thread overview]
Message-ID: <5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com> (raw)
In-Reply-To: <20240416095556.173787-1-sivaprasad.tummala@amd.com>
On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote:
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index ba1007ace6..6b28c22c96 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -4785,9 +4785,9 @@ fwd_stream_on_other_lcores(uint16_t domain_id, lcoreid_t src_lc,
> continue;
> printf("Shared Rx queue group %u queue %hu can't be scheduled on different cores:\n",
> share_group, share_rxq);
> - printf(" lcore %hhu Port %hu queue %hu\n",
> + printf(" lcore %u Port %hu queue %hu\n",
> src_lc, src_port, src_rxq);
> - printf(" lcore %hhu Port %hu queue %hu\n",
> + printf(" lcore %u Port %hu queue %hu\n",
> lc_id, fs->rx_port, fs->rx_queue);
> printf("Please use --nb-cores=%hu to limit number of forwarding cores\n",
> nb_rxq);
> @@ -5159,7 +5159,7 @@ icmp_echo_config_setup(void)
> lcoreid_t lc_id;
> uint16_t sm_id;
>
> - if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores)
> + if ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores)
> cur_fwd_config.nb_fwd_lcores = (lcoreid_t)
> (nb_txq * nb_fwd_ports);
>
Hi Sivaprasad,
Is this '(lcoreid_t)' cast required? Because of integer promotion I
think result will be correct without casting.
(And without integer promotion considered, casting needs to be done on
one of the variables, not to the result, because result may be already
cast down I think. Anyway this is not required for this case since
variables are u16.)
prev parent reply other threads:[~2024-04-19 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:46 [PATCH] app/testpmd: fix lcore ID restriction Sivaprasad Tummala
2024-04-15 21:54 ` Stephen Hemminger
2024-04-15 21:56 ` Stephen Hemminger
2024-04-16 9:55 ` [PATCH v2] " Sivaprasad Tummala
2024-04-19 8:24 ` Ferruh Yigit
2024-04-19 11:30 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).