From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH] i40e: prefetch next mbuf in rx alloc code Date: Fri, 10 Jul 2015 16:18:54 +0000 Message-ID: References: <1433974765-136411-1-git-send-email-damarion@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Damjan Marion Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 89E48C3D2 for ; Fri, 10 Jul 2015 18:18:58 +0200 (CEST) In-Reply-To: <1433974765-136411-1-git-send-email-damarion@cisco.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damjan Marion > Sent: Wednesday, June 10, 2015 3:19 PM > To: dev@dpdk.org > Cc: Damjan Marion > Subject: [dpdk-dev] [PATCH] i40e: prefetch next mbuf in rx alloc code >=20 > This patch improves performance of vectored rx on i40e devices. >=20 > Signed-off-by: Damjan Marion Acked-by: Helin Zhang with minor change requests. 1. commit log should be reworded. 2. likely should be added to the newly added if() line. 3. checkpatch.pl should be used to have a check. > --- > drivers/net/i40e/i40e_rxtx.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 2de0ac4..152e9e6 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -778,6 +778,11 @@ i40e_rx_alloc_bufs(struct i40e_rx_queue *rxq) >=20 > rxdp =3D &rxq->rx_ring[alloc_idx]; > for (i =3D 0; i < rxq->rx_free_thresh; i++) { > + > + /* Prefetch next mbuf */ > + if (i < (rxq->rx_free_thresh - 1)) > + rte_prefetch0 (rxep[i+1].mbuf); > + > mb =3D rxep[i].mbuf; > rte_mbuf_refcnt_set(mb, 1); > mb->next =3D NULL; > -- > 2.1.4