From: "Power, Ciara" <ciara.power@intel.com>
To: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"fanzhang.oss@gmail.com" <fanzhang.oss@gmail.com>
Subject: RE: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined
Date: Wed, 17 Apr 2024 11:40:56 +0000 [thread overview]
Message-ID: <SN7PR11MB7639C10E49BF57838326CE9CE60F2@SN7PR11MB7639.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240416081222.3002268-1-ganapati.kundapura@intel.com>
> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Tuesday, April 16, 2024 9:12 AM
> To: dev@dpdk.org
> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Power, Ciara
> <ciara.power@intel.com>; gakhil@marvell.com; fanzhang.oss@gmail.com
> Subject: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined
>
> Crypto callbacks macro is defined with value 1 and being used with ifdef, on
> config value is changed to 0 to disable, crypto callback changes still being
> compiled.
>
> Defined crypto callbacks macro without value, undef to disable
>
> Wrapped crypto callback changes with RTE_CRYPTO_CALLBACKS macro to fix
> build issues when macro is undefined.
>
> As callback head nodes have valid pointer, this patch checks the next node from
> the head if callbacks registered.
>
> Fixes: 1c3ffb9 ("cryptodev: add enqueue and dequeue callbacks")
> Fixes: 5523a75 ("test/crypto: add case for enqueue/dequeue callbacks")
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
>
Acked-by: Ciara Power <ciara.power@intel.com>
prev parent reply other threads:[~2024-04-17 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:12 [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Ganapati Kundapura
2024-04-16 9:16 ` Gujjar, Abhinandan S
2024-04-17 11:40 ` Power, Ciara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB7639C10E49BF57838326CE9CE60F2@SN7PR11MB7639.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=ganapati.kundapura@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).