From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDF2C4345F for ; Tue, 16 Apr 2024 08:26:07 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B066402AE; Tue, 16 Apr 2024 10:26:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 01A4E4029E; Tue, 16 Apr 2024 10:26:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713255964; x=1744791964; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2OQFQWcMO/5fma8E6f/5/kQWtQo/5kk+B5T3AlD3Z04=; b=WYqgWf2hDgiav3r0IRkkg68tnPHE6MTE/X/d9XkevZhNYhnHbA7wwpgs AMu50RErm55n/I3Pxehx5uGe6bMu3xY0QKXs5Do8H6F9aNvS5zoUfgciC hdUuGM3X+LrPe9klPiZldzw1qKIp0QMcRX7/NOSM8Jy/+E1M3lQR+DHss 2O331UPJpHPUiJKg6vCEJgd8u5bEa1Ih8GlGzjnsP770p19sotjqf24Ik X9oQqjBjxgDxNbZWxphwYNeAycAmk7sYwO6/lDkX+6vg3vKMU9aChPyrB gZaTlP4WBYMuavTvdJ4hw3O4mukkyhtTuFCbemuPqG4LPh+YNkWKWjL7M A==; X-CSE-ConnectionGUID: 8/1u6BFBRYidcP/sDE56Qg== X-CSE-MsgGUID: OrZ+Q0JNTVa+WtvrlbQe2w== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8543528" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="8543528" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 01:26:03 -0700 X-CSE-ConnectionGUID: JuzjDbHRTvW3hBY6ZTiEdw== X-CSE-MsgGUID: b9ruqfUUQWuy+pX88PQ82A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="53373432" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 01:26:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 01:26:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 01:26:01 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 01:26:01 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 01:25:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIA2qsh0toCqMWUaJlGtbEUNfdgglWi4LEkIONhA1fN7SmXdGBiDgD4lc3Fl+LnV8N07dM7L+qtc4AfXG2jqURCy/ZYQSGgCQiKKcxLZM5GMoDfdXzG+LFvI5fit+ltbk6BxiYxUAzzoodb+t8K3HHklvlGT6PD0J+jcoBa6UCmgHu4zkz253lveF7JNBStHQQ9fSsNjMcw1ina6A5XjYt+bqV4OaxjnXWZpVQ2v96gA4giH9/rRa9G2jyQyuJq3db8FHGkodIybHM1XkjFL13SYVaaY0YsclgokSQ8AgK0NPYCGlXzL/NjjOXdw5WkfO8auLmHtO1oxoRZFA2snpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7/b6TQO75c8XYtHPSulP1FJu7RWO2q4eTi6PcqxbY5w=; b=UwVQ9AqRMlmywq6kpfBJMHKcnxAEuFj3q6riZHv8EK+Xb0Ya6mmNF24JK9lMXBmfrehNJYPVzETbXUOmlAsu1VnrDkJWdbKR/pAZu1vvNWNcj6FFdHNbjMv82pRABshZNjG8skwNyEVmzCN45k1J5bBRFDxhw2hv12joSIUUzTnMGeT6vxMHtmu8jZ0fUfO73Wu11XebvN0xAnhjpKErQcEwRLS4e4pOY4FDJZBl5uMYb5utiVRQ1yJQGIxwZSsRaQcDCUUNSDAV6kD09ysy8wH0oVvF4dblYX8oASztBtoGiWYxPwLr4BZV5hvh7quM83YCOTL0WP2MgMe0tFYvWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CH3PR11MB7763.namprd11.prod.outlook.com (2603:10b6:610:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30; Tue, 16 Apr 2024 08:25:49 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::656e:3d48:9daa:7110%4]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 08:25:49 +0000 From: "Power, Ciara" To: "dev@dpdk.org" CC: "Gujjar, Abhinandan S" , "stable@dpdk.org" , Akhil Goyal , Fan Zhang , "Kundapura, Ganapati" Subject: RE: [PATCH] crypto: fix crypto callbacks macro Thread-Topic: [PATCH] crypto: fix crypto callbacks macro Thread-Index: AQHajzF9IuGurs+vSkSwTmkaoM5R8rFqkJPw Date: Tue, 16 Apr 2024 08:25:49 +0000 Message-ID: References: <20240415123548.705412-1-ciara.power@intel.com> In-Reply-To: <20240415123548.705412-1-ciara.power@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CH3PR11MB7763:EE_ x-ms-office365-filtering-correlation-id: a28a92e8-4b03-47e1-74c6-08dc5deed286 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0pK0gvBK/nAZiO0lcGbnUzEvx+R8PYvycNWWCg/JJvY3XwMDbmIkoRM77oh5COJLQB6LFhLqGj+bZiroyf2I2WG730FMo7OPQQorRQi8JbzAKB9GdWlM5aEekQpDNrpnOCAs9hnb21EN+3Oah2YCKCZPuKIWkZmBYOmJnp/spbZcfG52o7Dm13va30R531D0gEsL0XI7UsRl8T6c88DfPshf0+HX4TXjSkZTlDtCHf31AyAIpd54dsbCf3SSdN84H2x2fjV3jnaxJkr3p89S0Z6rL08D0b1pXm5Fmz7Nes1MBPRSx5Jq/WAc9cHW3kx43WSXwgDorK3E6a93MAzs0FyY/Y5bEmciTDykNmEjNxC9VMEHFlIBtgE1m/L7bYfMFdDHrXbccQytBDoU6Cu2gjKfdVq+CNEJkKGAQ79wjVxJeTmp7afosoFxrSjUH/JwnISPmjgKsSqS05t49QKHAjyjNEBUC/NpeOWP9VouM2Hae6ehrLfT23k+y/scDXTpOqq56oikpM6xeEEYFInY2Z5aaXuad9v3mbOdi+O61Y/xH3eQG1T+pV2nj5uHZsV5bY+rn7Qh/zu1JIYyu+Qc7D9drjiIPgt3QqR+b8Qc81pKJ3ZWOlNHWziHE22MQfYAa70EWO/q4N6ii3qB1IHqba6/fun6iz2crCd23cWyXHAHnp46Cx3JYu8EQO4wAx+FVIc1vjcojeds46SpAURQN0ZWAAW//waemRmIiTuZ9j0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5B50hxUlxhB/lAIcx4K7sqVqruHAiGLRZO6P3ejZywPLv1N+4zALQCUegKK3?= =?us-ascii?Q?H4BrTkz7OAbqKgRO7MsV0Cy3U0LZsQ43lIfrF6KpovjUHwDz8RQBlt9fp3Lg?= =?us-ascii?Q?+DjNN4nKnOkSJ50s+ZJrFmId122F2MSk//uqSnOrXD+HnTNNoMyT0pgp5bAT?= =?us-ascii?Q?UIky6xaBodeYdCthJmTZF8SD9KwxchRsyZ67xwFKTf9fgM1vq5X6BAHqXbhK?= =?us-ascii?Q?/IlLEkwU+JHwUUr70VhMCST6Xth1p36cOU5svIv/ARhVbMkkrvjvQ50XDgPb?= =?us-ascii?Q?7+Z2tariRBuUTG4ZnnxKZglZV/DKbcAYwIpMsUNfbqmCMyMTMMf36RgBPfSG?= =?us-ascii?Q?57iqhkVuIYBfVqITxrEadtv6pjA+m7ruEZ9fm2bFIixA/USkMVSMHZiIZKRL?= =?us-ascii?Q?yCYidSvI3S8L2DTLpdf6cIkIbURD38yR7YLHIRkStSvHcOuWOVEttR8BrVUP?= =?us-ascii?Q?AiF2P5Mx5C2ThZFIrqECX4qgPyfX4HARsV7sleHjb25VBmO/AbgpbL581OSW?= =?us-ascii?Q?acmp26Yr2SxIRKcIZeM2JFA7r65W1y2W1KSQRICb/utS6zZ1cHBDiQd1uJz1?= =?us-ascii?Q?iADa1xOymdzvKVMMZoFyQs8C3lnwqTiYaAHcILrtUzqBH8MVoOPpErERa+5M?= =?us-ascii?Q?IgbZnUbAyKat6K2UEB0zWL/xYV9uSYxfShZ7SGCbmTW16PDvJdRHT1RMfI+Y?= =?us-ascii?Q?9CgX8ib8Xk2ylGGxoq5cXXpM2c80zOZNDH41p2WqRoKDMrWO1f56AMaV84JV?= =?us-ascii?Q?DXLQUJU0N6Ij4CDZIXCiD2s4UYLODQ15KesdCu/mzhmXDBYY8kwa058BzlGP?= =?us-ascii?Q?dpUzzUiASv5UrP8cNIEwGKpIV46U7x282FafPmbdtmwtWCNnw//fuqL9OmY3?= =?us-ascii?Q?7cJaYMFGYXrAcQ+UJopjjUGbdmqq6Qe66HrkP3LgLgN8md4WimiX85gHHHFZ?= =?us-ascii?Q?bLH7kdtEQDE6qd6wufScXguutDEZAfCGG0QnLmWLbH+GbogIP8lnUFcyudbF?= =?us-ascii?Q?LNU9EdbsJqxHnn3HwWUIjoVoSTGcs+5ksHztqs1fqUuZ27ti0xbM0NzhG4d6?= =?us-ascii?Q?ZyoktY6O+yYGmvzIG4yyl3BPQuxkoWEyJTLgEkyVKiDmI1UdIMAOsYuWwEH7?= =?us-ascii?Q?hciunAb67b9UgXxFYWXPB0ycK6L0KHuQLH4NyU9x4thY6tn07CC9fHrXBUD4?= =?us-ascii?Q?zA8qus6THDQqUDVMLL2oBDWZVXf0g/poNldkkxHi8VSsiMEt9saEYwoHxwex?= =?us-ascii?Q?Yk0NHluQ2f5224A6dHcmP96pP6ja1Mw7+ibkLQmCXcv2zlZubJrE6ywsPLtU?= =?us-ascii?Q?6YmYUZe+dwv+AcFDB3Rx6Xi4z1ZlwYP3rqrp13E4Vo2b/CqNZ31WtFqz00Gf?= =?us-ascii?Q?01kHgIHj95E3nm6Pr1cYWdCISzNfKqoGhIllYbcgUWQ3jpS5JVMBxLul0zkI?= =?us-ascii?Q?ISnBqWsi1EOCdjnP5qZ2oYYKryQyZZRCcWpw1A85Gk/SVqRAGdqPVFao/xsn?= =?us-ascii?Q?HCLJNiZFktFIvqVso1FYoAaoHo8Ny533AqPTHHsbOP4GVcgGxCT2Rw2jWCvI?= =?us-ascii?Q?R7Qzk3T2j7vM/xJL2vu5WG6UCOhGHRoJST2AnBrd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a28a92e8-4b03-47e1-74c6-08dc5deed286 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 08:25:49.5270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PdkOJ6IUVl2NAyZlm30pXeLPnRLYefgFFypO3gbUCIRQpQKDuCI+dGThCaTBmwgWeu7e0/UoLdb6kOGO6w5/TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7763 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Power, Ciara > Sent: Monday, April 15, 2024 1:36 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Gujjar, Abhinandan S > ; stable@dpdk.org; Akhil Goyal > ; Fan Zhang > Subject: [PATCH] crypto: fix crypto callbacks macro >=20 > The crypto callbacks macro is being used with ifdef instead of if, so whe= n the > config file value is changed to 0 to disable, the code is still being com= piled in. >=20 > Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") > Cc: abhinandan.gujjar@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > --- > lib/cryptodev/rte_cryptodev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.= h index > 00ba6a234a..357d4bcf9c 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -1909,7 +1909,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, > uint16_t qp_id, >=20 > nb_ops =3D fp_ops->dequeue_burst(qp, ops, nb_ops); >=20 > -#ifdef RTE_CRYPTO_CALLBACKS > +#if RTE_CRYPTO_CALLBACKS > if (unlikely(fp_ops->qp.deq_cb !=3D NULL)) { > struct rte_cryptodev_cb_rcu *list; > struct rte_cryptodev_cb *cb; > @@ -1976,7 +1976,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, > uint16_t qp_id, >=20 > fp_ops =3D &rte_crypto_fp_ops[dev_id]; > qp =3D fp_ops->qp.data[qp_id]; > -#ifdef RTE_CRYPTO_CALLBACKS > +#if RTE_CRYPTO_CALLBACKS > if (unlikely(fp_ops->qp.enq_cb !=3D NULL)) { > struct rte_cryptodev_cb_rcu *list; > struct rte_cryptodev_cb *cb; > -- > 2.25.1 Rejecting this patch, as an alternative fix was sent along with some other = fixes: https://patchwork.dpdk.org/project/dpdk/patch/20240416081222.3002268= -1-ganapati.kundapura@intel.com/