* [PATCH v11 0/2] Add display-timing node parsing to exynos drm fimd
@ 2013-03-07 6:45 Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 1/2] video: drm: exynos: Add display-timing node parsing using video helper function Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd Vikas Sajjan
0 siblings, 2 replies; 3+ messages in thread
From: Vikas Sajjan @ 2013-03-07 6:45 UTC (permalink / raw
To: dri-devel
Cc: linux-media, kgene.kim, inki.dae, l.krishna, joshi, linaro-kernel
Add display-timing node parsing to drm fimd and depends on
the display helper patchset at
http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html
changes since v10:
- abandoned the pinctrl patch, as commented by Linus Walleij
<linus.walleij@linaro.org>
- added new patch to enable the OF_VIDEOMODE and FB_MODE_HELPERS for
EXYNOS DRM FIMD.
changes since v9:
- replaced IS_ERR_OR_NULL() with IS_ERR(), since IS_ERR_OR_NULL()
will be depreciated, as discussed at
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-January/140543.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg78030.html
changes since v8:
- replaced IS_ERR() with IS_ERR_OR_NULL(),
because devm_pinctrl_get_select_default can return NULL,
If CONFIG_PINCTRL is disabled.
- modified the error log, such that it shall NOT cross 80 column.
- added Acked-by.
changes since v7:
- addressed comments from Joonyoung Shim <jy0922.shim@samsung.com>
to remove a unnecessary variable.
changes since v6:
addressed comments from Inki Dae <inki.dae@samsung.com> to
separated out the pinctrl functionality and made a separate patch.
changes since v5:
- addressed comments from Inki Dae <inki.dae@samsung.com>,
to remove the allocation of 'fbmode' and replaced
'-1'in "of_get_fb_videomode(dev->of_node, fbmode, -1)" with
OF_USE_NATIVE_MODE.
changes since v4:
- addressed comments from Paul Menzel
<paulepanter@users.sourceforge.net>, to modify the commit message
changes since v3:
- addressed comments from Sean Paul <seanpaul@chromium.org>, to modify
the return values and print messages.
changes since v2:
- moved 'devm_pinctrl_get_select_default' function call under
'if (pdev->dev.of_node)', this makes NON-DT code unchanged.
(reported by: Rahul Sharma <r.sh.open@gmail.com>)
changes since v1:
- addressed comments from Sean Paul <seanpaul@chromium.org>
Vikas Sajjan (2):
video: drm: exynos: Add display-timing node parsing using video
helper function
drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm
fimd
drivers/gpu/drm/exynos/Kconfig | 2 ++
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 27 +++++++++++++++++++++++----
2 files changed, 25 insertions(+), 4 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v11 1/2] video: drm: exynos: Add display-timing node parsing using video helper function
2013-03-07 6:45 [PATCH v11 0/2] Add display-timing node parsing to exynos drm fimd Vikas Sajjan
@ 2013-03-07 6:45 ` Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd Vikas Sajjan
1 sibling, 0 replies; 3+ messages in thread
From: Vikas Sajjan @ 2013-03-07 6:45 UTC (permalink / raw
To: dri-devel
Cc: linux-media, kgene.kim, inki.dae, l.krishna, joshi, linaro-kernel
Add support for parsing the display-timing node using video helper
function.
The DT node parsing is done only if 'dev.of_node'
exists and the NON-DT logic is still maintained under the 'else' part.
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 9537761..f322ec3 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -20,6 +20,7 @@
#include <linux/of_device.h>
#include <linux/pm_runtime.h>
+#include <video/of_display_timing.h>
#include <video/samsung_fimd.h>
#include <drm/exynos_drm.h>
@@ -883,10 +884,25 @@ static int fimd_probe(struct platform_device *pdev)
DRM_DEBUG_KMS("%s\n", __FILE__);
- pdata = pdev->dev.platform_data;
- if (!pdata) {
- dev_err(dev, "no platform data specified\n");
- return -EINVAL;
+ if (pdev->dev.of_node) {
+ pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
+ if (!pdata) {
+ DRM_ERROR("memory allocation for pdata failed\n");
+ return -ENOMEM;
+ }
+
+ ret = of_get_fb_videomode(dev->of_node, &pdata->panel.timing,
+ OF_USE_NATIVE_MODE);
+ if (ret) {
+ DRM_ERROR("failed: of_get_fb_videomode() : %d\n", ret);"
+ return ret;
+ }
+ } else {
+ pdata = pdev->dev.platform_data;
+ if (!pdata) {
+ DRM_ERROR("no platform data specified\n");
+ return -EINVAL;
+ }
}
panel = &pdata->panel;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v11 2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd
2013-03-07 6:45 [PATCH v11 0/2] Add display-timing node parsing to exynos drm fimd Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 1/2] video: drm: exynos: Add display-timing node parsing using video helper function Vikas Sajjan
@ 2013-03-07 6:45 ` Vikas Sajjan
1 sibling, 0 replies; 3+ messages in thread
From: Vikas Sajjan @ 2013-03-07 6:45 UTC (permalink / raw
To: dri-devel
Cc: linux-media, kgene.kim, inki.dae, l.krishna, joshi, linaro-kernel
patch adds "select OF_VIDEOMODE" and "select FB_MODE_HELPERS" when
EXYNOS_DRM_FIMD config is selected.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
drivers/gpu/drm/exynos/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 046bcda..bb25130 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -25,6 +25,8 @@ config DRM_EXYNOS_DMABUF
config DRM_EXYNOS_FIMD
bool "Exynos DRM FIMD"
depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
+ select OF_VIDEOMODE
+ select FB_MODE_HELPERS
help
Choose this option if you want to use Exynos FIMD for DRM.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-07 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 6:45 [PATCH v11 0/2] Add display-timing node parsing to exynos drm fimd Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 1/2] video: drm: exynos: Add display-timing node parsing using video helper function Vikas Sajjan
2013-03-07 6:45 ` [PATCH v11 2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd Vikas Sajjan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).