* [PATCH] accel/ivpu: Don't enable any tiles by default on VPU40xx
@ 2024-02-20 11:08 Jacek Lawrynowicz
2024-02-20 13:16 ` [PATCH v2] " Jacek Lawrynowicz
0 siblings, 1 reply; 4+ messages in thread
From: Jacek Lawrynowicz @ 2024-02-20 11:08 UTC (permalink / raw
To: dri-devel
Cc: oded.gabbay, quic_jhugo, stable, Andrzej Kacprowski,
Jacek Lawrynowicz
From: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
There is no point in requesting 1 tile on VPU40xx as the FW will
probably need more tiles to run workloads, so it will have to
reconfigure PLL anyway. Don't enable any tiles and allow the FW to
perform initial tile configuration.
This improves NPU boot stability as the tiles are always enabled only
by the FW from the same initial state.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_40xx.c b/drivers/accel/ivpu/ivpu_hw_40xx.c
index 1c995307c113..a1523d0b1ef3 100644
--- a/drivers/accel/ivpu/ivpu_hw_40xx.c
+++ b/drivers/accel/ivpu/ivpu_hw_40xx.c
@@ -24,7 +24,7 @@
#define SKU_HW_ID_SHIFT 16u
#define SKU_HW_ID_MASK 0xffff0000u
-#define PLL_CONFIG_DEFAULT 0x1
+#define PLL_CONFIG_DEFAULT 0x0
#define PLL_CDYN_DEFAULT 0x80
#define PLL_EPP_DEFAULT 0x80
#define PLL_REF_CLK_FREQ (50 * 1000000)
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] accel/ivpu: Don't enable any tiles by default on VPU40xx
2024-02-20 11:08 [PATCH] accel/ivpu: Don't enable any tiles by default on VPU40xx Jacek Lawrynowicz
@ 2024-02-20 13:16 ` Jacek Lawrynowicz
2024-02-20 14:42 ` Jeffrey Hugo
2024-02-20 16:34 ` Jacek Lawrynowicz
0 siblings, 2 replies; 4+ messages in thread
From: Jacek Lawrynowicz @ 2024-02-20 13:16 UTC (permalink / raw
To: dri-devel
Cc: oded.gabbay, quic_jhugo, Andrzej Kacprowski, stable,
Jacek Lawrynowicz
From: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
There is no point in requesting 1 tile on VPU40xx as the FW will
probably need more tiles to run workloads, so it will have to
reconfigure PLL anyway. Don't enable any tiles and allow the FW to
perform initial tile configuration.
This improves NPU boot stability as the tiles are always enabled only
by the FW from the same initial state.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Cc: stable@vger.kernel.org
Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_40xx.c b/drivers/accel/ivpu/ivpu_hw_40xx.c
index 1c995307c113..a1523d0b1ef3 100644
--- a/drivers/accel/ivpu/ivpu_hw_40xx.c
+++ b/drivers/accel/ivpu/ivpu_hw_40xx.c
@@ -24,7 +24,7 @@
#define SKU_HW_ID_SHIFT 16u
#define SKU_HW_ID_MASK 0xffff0000u
-#define PLL_CONFIG_DEFAULT 0x1
+#define PLL_CONFIG_DEFAULT 0x0
#define PLL_CDYN_DEFAULT 0x80
#define PLL_EPP_DEFAULT 0x80
#define PLL_REF_CLK_FREQ (50 * 1000000)
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] accel/ivpu: Don't enable any tiles by default on VPU40xx
2024-02-20 13:16 ` [PATCH v2] " Jacek Lawrynowicz
@ 2024-02-20 14:42 ` Jeffrey Hugo
2024-02-20 16:34 ` Jacek Lawrynowicz
1 sibling, 0 replies; 4+ messages in thread
From: Jeffrey Hugo @ 2024-02-20 14:42 UTC (permalink / raw
To: Jacek Lawrynowicz, dri-devel; +Cc: oded.gabbay, Andrzej Kacprowski, stable
On 2/20/2024 6:16 AM, Jacek Lawrynowicz wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
>
> There is no point in requesting 1 tile on VPU40xx as the FW will
> probably need more tiles to run workloads, so it will have to
> reconfigure PLL anyway. Don't enable any tiles and allow the FW to
> perform initial tile configuration.
>
> This improves NPU boot stability as the tiles are always enabled only
> by the FW from the same initial state.
>
> Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] accel/ivpu: Don't enable any tiles by default on VPU40xx
2024-02-20 13:16 ` [PATCH v2] " Jacek Lawrynowicz
2024-02-20 14:42 ` Jeffrey Hugo
@ 2024-02-20 16:34 ` Jacek Lawrynowicz
1 sibling, 0 replies; 4+ messages in thread
From: Jacek Lawrynowicz @ 2024-02-20 16:34 UTC (permalink / raw
To: dri-devel; +Cc: oded.gabbay, quic_jhugo, Andrzej Kacprowski, stable
Applied to drm-misc-fixes
On 20.02.2024 14:16, Jacek Lawrynowicz wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
>
> There is no point in requesting 1 tile on VPU40xx as the FW will
> probably need more tiles to run workloads, so it will have to
> reconfigure PLL anyway. Don't enable any tiles and allow the FW to
> perform initial tile configuration.
>
> This improves NPU boot stability as the tiles are always enabled only
> by the FW from the same initial state.
>
> Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_hw_40xx.c b/drivers/accel/ivpu/ivpu_hw_40xx.c
> index 1c995307c113..a1523d0b1ef3 100644
> --- a/drivers/accel/ivpu/ivpu_hw_40xx.c
> +++ b/drivers/accel/ivpu/ivpu_hw_40xx.c
> @@ -24,7 +24,7 @@
> #define SKU_HW_ID_SHIFT 16u
> #define SKU_HW_ID_MASK 0xffff0000u
>
> -#define PLL_CONFIG_DEFAULT 0x1
> +#define PLL_CONFIG_DEFAULT 0x0
> #define PLL_CDYN_DEFAULT 0x80
> #define PLL_EPP_DEFAULT 0x80
> #define PLL_REF_CLK_FREQ (50 * 1000000)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-20 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 11:08 [PATCH] accel/ivpu: Don't enable any tiles by default on VPU40xx Jacek Lawrynowicz
2024-02-20 13:16 ` [PATCH v2] " Jacek Lawrynowicz
2024-02-20 14:42 ` Jeffrey Hugo
2024-02-20 16:34 ` Jacek Lawrynowicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).