* [PATCH 0/7] backlight: Simplify probe in few drivers
@ 2024-03-04 10:11 Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Hi,
Simplify old code in few backlight drivers.
Best regards,
Krzysztof
---
Krzysztof Kozlowski (7):
backlight: gpio: Simplify with dev_err_probe()
backlight: l4f00242t03: Simplify with dev_err_probe()
backlight: bd6107: Handle deferred probe
backlight: as3711_bl: Handle deferred probe
backlight: lm3630a_bl: Handle deferred probe
backlight: lm3630a_bl: Simplify probe return on gpio request error
backlight: pandora_bl: Drop unneeded ENOMEM error message
drivers/video/backlight/as3711_bl.c | 6 ++----
drivers/video/backlight/bd6107.c | 9 +++------
drivers/video/backlight/gpio_backlight.c | 10 +++-------
drivers/video/backlight/l4f00242t03.c | 34 +++++++++++++-------------------
drivers/video/backlight/lm3630a_bl.c | 13 +++++-------
drivers/video/backlight/pandora_bl.c | 4 +---
6 files changed, 28 insertions(+), 48 deletions(-)
---
base-commit: 1870cdc0e8dee32e3c221704a2977898ba4c10e8
change-id: 20240304-backlight-probe-31dee1efe662
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:40 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/gpio_backlight.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index d28c30b2a35d..9f960f853b6e 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
def_value = device_property_read_bool(dev, "default-on");
gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
- if (IS_ERR(gbl->gpiod)) {
- ret = PTR_ERR(gbl->gpiod);
- if (ret != -EPROBE_DEFER)
- dev_err(dev,
- "Error: The gpios parameter is missing or invalid.\n");
- return ret;
- }
+ if (IS_ERR(gbl->gpiod))
+ return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
+ "Error: The gpios parameter is missing or invalid.\n");
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/7] backlight: l4f00242t03: Simplify with dev_err_probe()
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:40 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/l4f00242t03.c | 34 ++++++++++++++--------------------
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index cc763cf15f53..bd5137ee203b 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -179,34 +179,28 @@ static int l4f00242t03_probe(struct spi_device *spi)
priv->spi = spi;
priv->reset = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_HIGH);
- if (IS_ERR(priv->reset)) {
- dev_err(&spi->dev,
- "Unable to get the lcd l4f00242t03 reset gpio.\n");
- return PTR_ERR(priv->reset);
- }
+ if (IS_ERR(priv->reset))
+ return dev_err_probe(&spi->dev, PTR_ERR(priv->reset),
+ "Unable to get the lcd l4f00242t03 reset gpio.\n");
gpiod_set_consumer_name(priv->reset, "lcd l4f00242t03 reset");
priv->enable = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
- if (IS_ERR(priv->enable)) {
- dev_err(&spi->dev,
- "Unable to get the lcd l4f00242t03 data en gpio.\n");
- return PTR_ERR(priv->enable);
- }
+ if (IS_ERR(priv->enable))
+ return dev_err_probe(&spi->dev, PTR_ERR(priv->enable),
+ "Unable to get the lcd l4f00242t03 data en gpio.\n");
gpiod_set_consumer_name(priv->enable, "lcd l4f00242t03 data enable");
priv->io_reg = devm_regulator_get(&spi->dev, "vdd");
- if (IS_ERR(priv->io_reg)) {
- dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
- __func__);
- return PTR_ERR(priv->io_reg);
- }
+ if (IS_ERR(priv->io_reg))
+ return dev_err_probe(&spi->dev, PTR_ERR(priv->io_reg),
+ "%s: Unable to get the IO regulator\n",
+ __func__);
priv->core_reg = devm_regulator_get(&spi->dev, "vcore");
- if (IS_ERR(priv->core_reg)) {
- dev_err(&spi->dev, "%s: Unable to get the core regulator\n",
- __func__);
- return PTR_ERR(priv->core_reg);
- }
+ if (IS_ERR(priv->core_reg))
+ return dev_err_probe(&spi->dev, PTR_ERR(priv->core_reg),
+ "%s: Unable to get the core regulator\n",
+ __func__);
priv->ld = devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev,
priv, &l4f_ops);
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/7] backlight: bd6107: Handle deferred probe
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:41 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
` (3 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/bd6107.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c
index c95a12bf0ce2..b1e7126380ef 100644
--- a/drivers/video/backlight/bd6107.c
+++ b/drivers/video/backlight/bd6107.c
@@ -119,7 +119,6 @@ static int bd6107_probe(struct i2c_client *client)
struct backlight_device *backlight;
struct backlight_properties props;
struct bd6107 *bd;
- int ret;
if (pdata == NULL) {
dev_err(&client->dev, "No platform data\n");
@@ -147,11 +146,9 @@ static int bd6107_probe(struct i2c_client *client)
* the reset.
*/
bd->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
- if (IS_ERR(bd->reset)) {
- dev_err(&client->dev, "unable to request reset GPIO\n");
- ret = PTR_ERR(bd->reset);
- return ret;
- }
+ if (IS_ERR(bd->reset))
+ return dev_err_probe(&client->dev, PTR_ERR(bd->reset),
+ "unable to request reset GPIO\n");
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/7] backlight: as3711_bl: Handle deferred probe
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:42 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 5/7] backlight: lm3630a_bl: " Krzysztof Kozlowski
` (2 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/as3711_bl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c
index 28437c2da0f5..e6f66bb35ef5 100644
--- a/drivers/video/backlight/as3711_bl.c
+++ b/drivers/video/backlight/as3711_bl.c
@@ -383,10 +383,8 @@ static int as3711_backlight_probe(struct platform_device *pdev)
if (pdev->dev.parent->of_node) {
ret = as3711_backlight_parse_dt(&pdev->dev);
- if (ret < 0) {
- dev_err(&pdev->dev, "DT parsing failed: %d\n", ret);
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret, "DT parsing failed\n");
}
if (!pdata->su1_fb && !pdata->su2_fb) {
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/7] backlight: lm3630a_bl: Handle deferred probe
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
` (3 preceding siblings ...)
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:44 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/lm3630a_bl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index a3412c936ca2..93fd6dbccc28 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client)
/* pwm */
if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) {
pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm");
- if (IS_ERR(pchip->pwmd)) {
- dev_err(&client->dev, "fail : get pwm device\n");
- return PTR_ERR(pchip->pwmd);
- }
+ if (IS_ERR(pchip->pwmd))
+ return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd),
+ "fail : get pwm device\n");
pwm_init_state(pchip->pwmd, &pchip->pwmd_state);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
` (4 preceding siblings ...)
2024-03-04 10:11 ` [PATCH 5/7] backlight: lm3630a_bl: " Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 10:46 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Code can be simpler: return directly when devm_gpiod_get_optional()
failed.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/lm3630a_bl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index 93fd6dbccc28..ac0a60e39e39 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -543,10 +543,8 @@ static int lm3630a_probe(struct i2c_client *client)
pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
GPIOD_OUT_HIGH);
- if (IS_ERR(pchip->enable_gpio)) {
- rval = PTR_ERR(pchip->enable_gpio);
- return rval;
- }
+ if (IS_ERR(pchip->enable_gpio))
+ return PTR_ERR(pchip->enable_gpio);
/* chip initialize */
rval = lm3630a_chip_init(pchip);
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
` (5 preceding siblings ...)
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
@ 2024-03-04 10:11 ` Krzysztof Kozlowski
2024-03-04 11:08 ` Daniel Thompson
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 10:11 UTC (permalink / raw
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: dri-devel, linux-fbdev, linux-kernel, Krzysztof Kozlowski
Core code already prints detailed information about failure of memory
allocation.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/pandora_bl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pandora_bl.c b/drivers/video/backlight/pandora_bl.c
index f946470ce9f6..51faa889e01f 100644
--- a/drivers/video/backlight/pandora_bl.c
+++ b/drivers/video/backlight/pandora_bl.c
@@ -114,10 +114,8 @@ static int pandora_backlight_probe(struct platform_device *pdev)
u8 r;
priv = devm_kmalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "failed to allocate driver private data\n");
+ if (!priv)
return -ENOMEM;
- }
memset(&props, 0, sizeof(props));
props.max_brightness = MAX_USER_VALUE;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2024-03-04 10:40 ` Daniel Thompson
2024-03-05 8:09 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:40 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/video/backlight/gpio_backlight.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index d28c30b2a35d..9f960f853b6e 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> def_value = device_property_read_bool(dev, "default-on");
>
> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
> - if (IS_ERR(gbl->gpiod)) {
> - ret = PTR_ERR(gbl->gpiod);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev,
> - "Error: The gpios parameter is missing or invalid.\n");
> - return ret;
> - }
> + if (IS_ERR(gbl->gpiod))
> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
> + "Error: The gpios parameter is missing or invalid.\n");
The "Error: " should be removed from the string. dev_err_probe() already prints
that.
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/7] backlight: l4f00242t03: Simplify with dev_err_probe()
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
@ 2024-03-04 10:40 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:40 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:39AM +0100, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/7] backlight: bd6107: Handle deferred probe
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
@ 2024-03-04 10:41 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:41 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:40AM +0100, Krzysztof Kozlowski wrote:
> Don't pollute dmesg on deferred probe and simplify the code with
> dev_err_probe().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/7] backlight: as3711_bl: Handle deferred probe
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
@ 2024-03-04 10:42 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:42 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:41AM +0100, Krzysztof Kozlowski wrote:
> Don't pollute dmesg on deferred probe and simplify the code with
> dev_err_probe().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5/7] backlight: lm3630a_bl: Handle deferred probe
2024-03-04 10:11 ` [PATCH 5/7] backlight: lm3630a_bl: " Krzysztof Kozlowski
@ 2024-03-04 10:44 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:44 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:42AM +0100, Krzysztof Kozlowski wrote:
> Don't pollute dmesg on deferred probe and simplify the code with
> dev_err_probe().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
@ 2024-03-04 10:46 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 10:46 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:43AM +0100, Krzysztof Kozlowski wrote:
> Code can be simpler: return directly when devm_gpiod_get_optional()
> failed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
@ 2024-03-04 11:08 ` Daniel Thompson
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Thompson @ 2024-03-04 11:08 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On Mon, Mar 04, 2024 at 11:11:44AM +0100, Krzysztof Kozlowski wrote:
> Core code already prints detailed information about failure of memory
> allocation.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()
2024-03-04 10:40 ` Daniel Thompson
@ 2024-03-05 8:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-05 8:09 UTC (permalink / raw
To: Daniel Thompson
Cc: Lee Jones, Jingoo Han, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
On 04/03/2024 11:40, Daniel Thompson wrote:
> On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote:
>> Common pattern of handling deferred probe can be simplified with
>> dev_err_probe(). Less code and also it prints the error value.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/video/backlight/gpio_backlight.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
>> index d28c30b2a35d..9f960f853b6e 100644
>> --- a/drivers/video/backlight/gpio_backlight.c
>> +++ b/drivers/video/backlight/gpio_backlight.c
>> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
>> def_value = device_property_read_bool(dev, "default-on");
>>
>> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
>> - if (IS_ERR(gbl->gpiod)) {
>> - ret = PTR_ERR(gbl->gpiod);
>> - if (ret != -EPROBE_DEFER)
>> - dev_err(dev,
>> - "Error: The gpios parameter is missing or invalid.\n");
>> - return ret;
>> - }
>> + if (IS_ERR(gbl->gpiod))
>> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
>> + "Error: The gpios parameter is missing or invalid.\n");
>
> The "Error: " should be removed from the string. dev_err_probe() already prints
> that.
Sure.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-03-05 8:09 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
2024-03-04 10:40 ` Daniel Thompson
2024-03-05 8:09 ` Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-03-04 10:40 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
2024-03-04 10:41 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
2024-03-04 10:42 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 5/7] backlight: lm3630a_bl: " Krzysztof Kozlowski
2024-03-04 10:44 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
2024-03-04 10:46 ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
2024-03-04 11:08 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).