From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Douglas Anderson <dianders@chromium.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Vinod Koul <vkoul@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH RFC 4/7] drm/panel: innolux-p079zca: use mipi_dsi_dcs_nop_multi()
Date: Fri, 10 May 2024 01:37:37 +0300 [thread overview]
Message-ID: <20240510-dsi-panels-upd-api-v1-4-317c78a0dcc8@linaro.org> (raw)
In-Reply-To: <20240510-dsi-panels-upd-api-v1-0-317c78a0dcc8@linaro.org>
Remove conditional code and use mipi_dsi_dcs_nop_multi() wrapper to
simplify driver code.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index ade8bf7491ee..0691a27a0daa 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -224,21 +224,14 @@ static const struct drm_display_mode innolux_p097pfg_mode = {
static void innolux_panel_write_multi(struct mipi_dsi_multi_context *ctx,
const void *payload, size_t size)
{
- struct mipi_dsi_device *dsi = ctx->dsi;
- struct device *dev = &dsi->dev;
-
mipi_dsi_generic_write_multi(ctx, payload, size);
- if (ctx->accum_err)
- return;
/*
* Included by random guessing, because without this
* (or at least, some delay), the panel sometimes
* didn't appear to pick up the command sequence.
*/
- ctx->accum_err = mipi_dsi_dcs_nop(ctx->dsi);
- if (ctx->accum_err)
- dev_err(dev, "failed to send DCS nop: %d\n", ctx->accum_err);
+ mipi_dsi_dcs_nop_multi(ctx);
}
#define innolux_panel_init_cmd_multi(ctx, seq...) \
--
2.39.2
next prev parent reply other threads:[~2024-05-09 22:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 22:37 [PATCH RFC 0/7] drm/mipi-dsi: simplify MIPI DSI init/cleanup even more Dmitry Baryshkov
2024-05-09 22:37 ` [PATCH RFC 1/7] drm/mipi-dsi: wrap more functions for streamline handling Dmitry Baryshkov
2024-05-10 21:45 ` Doug Anderson
2024-05-10 22:22 ` Dmitry Baryshkov
2024-05-09 22:37 ` [PATCH RFC 2/7] drm/panel: boe-tv101wum-nl6: use wrapped MIPI DCS functions Dmitry Baryshkov
2024-05-10 21:46 ` Doug Anderson
2024-05-09 22:37 ` [PATCH RFC 3/7] drm/panel: ilitek-ili9882t: " Dmitry Baryshkov
2024-05-10 21:46 ` Doug Anderson
2024-05-09 22:37 ` Dmitry Baryshkov [this message]
2024-05-10 21:46 ` [PATCH RFC 4/7] drm/panel: innolux-p079zca: use mipi_dsi_dcs_nop_multi() Doug Anderson
2024-05-09 22:37 ` [PATCH RFC 5/7] drm/panel: novatek-nt36672e: use wrapped MIPI DCS functions Dmitry Baryshkov
2024-05-10 21:46 ` Doug Anderson
2024-05-09 22:37 ` [PATCH RFC 6/7] drm/panel: lg-sw43408: add missing error handling Dmitry Baryshkov
2024-05-10 21:47 ` Doug Anderson
2024-05-10 22:25 ` Dmitry Baryshkov
2024-05-10 22:28 ` Doug Anderson
2024-05-09 22:37 ` [PATCH RFC 7/7] drm/panel: lg-sw43408: use new streamlined MIPI DSI API Dmitry Baryshkov
2024-05-10 21:47 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510-dsi-panels-upd-api-v1-4-317c78a0dcc8@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).