From: Krzysztof Kozlowski <krzk@kernel.org>
To: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"mripard@kernel.org" <mripard@kernel.org>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"kishon@kernel.org" <kishon@kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Add dp PHY dt-bindings
Date: Mon, 13 May 2024 16:20:59 +0200 [thread overview]
Message-ID: <4a147f2d-71c8-4acf-aab4-9d761b81bc73@kernel.org> (raw)
In-Reply-To: <f4f85f0b-49eb-4fba-ac76-2df845571b12@kernel.org>
On 13/05/2024 16:17, Krzysztof Kozlowski wrote:
>>> dp.yaml
>>>> @@ -0,0 +1,45 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id:
>>> http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: MediaTek Display Port Controller
>>>> +
>>>> +maintainers:
>>>> + - Mac shen <mac.shen@mediatek.com>
>>>> + - Liankun yang <Liankun.yang@mediatek.com>
>>>> +
>>>> +description: |
>>>> + Special settings need to be configured by MediaTek DP based on
>>> the actual
>>>> + hardware situation. For example, when using a certain brand's
>>> docking
>>>> + station for display projection, garbage may appear. Adjusting
>>> the specific
>>>> + ssc value can resolve this issue.
>>>> +
>>>> +properties:
>>>> + status: disabled
>>>
>>> I think you nicely shocked Rob already.
>>>
>>> Please reach internally to Mediatek or collaborating companies to get
>>> basic training and instructions how to write patches and bindings.
>>>
>>> Otherwise it is waste of our time. Mediatek is not a small company so
>>> there is no excuse in sending such poor quality patches, which would
>>> be
>>> EASILY spotted by the MOST BASIC review.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I used scripts/checkpatch.pl and fix reported error and warnings.
>> I am resumbmitting bindings by the MOST BASIC review.
>
> No, please wait. Who did the basic review of your patch? Who from
> Mediatek? Upstream is not a workhorse to use instead of your resources
> for the absolute basic stuff... This feels such exploiting.
>
After reading AngeloGioacchino's response, it looks even worse... This
was never tested...
So not only exploiting but also feels like wasting our time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-13 14:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:04 [PATCH v2 0/2] Add PHY-dp bindings Liankun Yang
2024-05-10 11:04 ` [PATCH v2 1/2] Add write DP phyd register from parse dts Liankun Yang
2024-05-13 6:38 ` Krzysztof Kozlowski
2024-05-13 14:21 ` LIANKUN YANG (杨连坤)
2024-05-13 13:11 ` AngeloGioacchino Del Regno
2024-05-13 14:26 ` LIANKUN YANG (杨连坤)
2024-05-10 11:04 ` [PATCH v2 2/2] Add dp PHY dt-bindings Liankun Yang
2024-05-10 12:48 ` Rob Herring
2024-05-13 14:06 ` LIANKUN YANG (杨连坤)
2024-05-13 6:37 ` Krzysztof Kozlowski
2024-05-13 14:15 ` LIANKUN YANG (杨连坤)
2024-05-13 14:17 ` Krzysztof Kozlowski
2024-05-13 14:20 ` Krzysztof Kozlowski [this message]
2024-05-14 4:43 ` LIANKUN YANG (杨连坤)
2024-05-10 11:27 ` [PATCH v2 0/2] Add PHY-dp bindings Jani Nikula
2024-05-13 13:57 ` LIANKUN YANG (杨连坤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a147f2d-71c8-4acf-aab4-9d761b81bc73@kernel.org \
--to=krzk@kernel.org \
--cc=Chunfeng.Yun@mediatek.com \
--cc=Liankun.Yang@mediatek.com \
--cc=Mac.Shen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).