* [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()
@ 2024-01-03 14:17 chenguanxi11234
2024-01-03 17:37 ` Jessica Zhang
2024-01-12 9:35 ` neil.armstrong
0 siblings, 2 replies; 3+ messages in thread
From: chenguanxi11234 @ 2024-01-03 14:17 UTC (permalink / raw
To: neil.armstrong
Cc: cgel.zte, linux-kernel, mripard, Chen Haonan, yang.guang5,
dri-devel, tzimmermann, quic_jesszhan, sam
From: Chen Haonan <chen.haonan2@zte.com.cn>
dev_err_probe() can check if the error code is -EPROBE_DEFER
and can return the error code, replacing dev_err() with it
simplifies the code.
Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn>
---
drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
index 79f611963c61..f4103e762b53 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
@@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
GPIOD_OUT_HIGH);
if (IS_ERR(s6->reset_gpio)) {
- ret = PTR_ERR(s6->reset_gpio);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to request GPIO (%d)\n", ret);
- return ret;
+ return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
+ "failed to request GPIO\n");
}
drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()
2024-01-03 14:17 [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe() chenguanxi11234
@ 2024-01-03 17:37 ` Jessica Zhang
2024-01-12 9:35 ` neil.armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Jessica Zhang @ 2024-01-03 17:37 UTC (permalink / raw
To: chenguanxi11234, neil.armstrong
Cc: cgel.zte, linux-kernel, dri-devel, Chen Haonan, yang.guang5,
mripard, tzimmermann, sam
On 1/3/2024 6:17 AM, chenguanxi11234@163.com wrote:
> From: Chen Haonan <chen.haonan2@zte.com.cn>
>
> dev_err_probe() can check if the error code is -EPROBE_DEFER
> and can return the error code, replacing dev_err() with it
> simplifies the code.
>
> Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> index 79f611963c61..f4103e762b53 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> @@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
> s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(s6->reset_gpio)) {
> - ret = PTR_ERR(s6->reset_gpio);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to request GPIO (%d)\n", ret);
> - return ret;
> + return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
> + "failed to request GPIO\n");
> }
>
> drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()
2024-01-03 14:17 [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe() chenguanxi11234
2024-01-03 17:37 ` Jessica Zhang
@ 2024-01-12 9:35 ` neil.armstrong
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2024-01-12 9:35 UTC (permalink / raw
To: chenguanxi11234
Cc: cgel.zte, linux-kernel, mripard, Chen Haonan, yang.guang5,
dri-devel, tzimmermann, quic_jesszhan, sam
On 03/01/2024 15:17, chenguanxi11234@163.com wrote:
> From: Chen Haonan <chen.haonan2@zte.com.cn>
>
> dev_err_probe() can check if the error code is -EPROBE_DEFER
> and can return the error code, replacing dev_err() with it
> simplifies the code.
>
> Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> index 79f611963c61..f4103e762b53 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> @@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
> s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(s6->reset_gpio)) {
> - ret = PTR_ERR(s6->reset_gpio);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to request GPIO (%d)\n", ret);
> - return ret;
> + return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
> + "failed to request GPIO\n");
> }
>
> drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
This patch fails to apply on current drm-misc-next, please refresh.
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-12 9:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 14:17 [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe() chenguanxi11234
2024-01-03 17:37 ` Jessica Zhang
2024-01-12 9:35 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).