From: Helen Koike <helen.koike@collabora.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
dri-devel@lists.freedesktop.org
Cc: daniels@collabora.com, airlied@gmail.com, daniel@ffwll.ch,
robdclark@gmail.com, david.heidelberg@collabora.com,
guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
dmitry.baryshkov@linaro.org, mcanal@igalia.com,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org,
amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] drm/ci: build virtual GPU driver as module
Date: Tue, 30 Apr 2024 11:31:16 -0300 [thread overview]
Message-ID: <90a0b4ba-52e3-446e-8de1-ca67e0c71a53@collabora.com> (raw)
In-Reply-To: <20240430091121.508099-4-vignesh.raman@collabora.com>
On 30/04/2024 06:11, Vignesh Raman wrote:
> With latest IGT, the tests tries to load the module and it
> fails. So build the virtual GPU driver for virtio as module.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> drivers/gpu/drm/ci/build.sh | 1 -
> drivers/gpu/drm/ci/igt_runner.sh | 6 +++---
> drivers/gpu/drm/ci/image-tags.yml | 4 ++--
> drivers/gpu/drm/ci/test.yml | 1 +
> drivers/gpu/drm/ci/x86_64.config | 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
> index 8a3baa003904..95493df9cdc2 100644
> --- a/drivers/gpu/drm/ci/build.sh
> +++ b/drivers/gpu/drm/ci/build.sh
> @@ -156,7 +156,6 @@ fi
>
> mkdir -p artifacts/install/lib
> mv install/* artifacts/install/.
> -rm -rf artifacts/install/modules
> ln -s common artifacts/install/ci-common
> cp .config artifacts/${CI_JOB_NAME}_config
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 20026612a9bd..55532f79fbdc 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -30,10 +30,10 @@ case "$DRIVER_NAME" in
> export IGT_FORCE_DRIVER="panfrost"
> fi
> ;;
> - amdgpu)
> + amdgpu|virtio_gpu)
> # Cannot use HWCI_KERNEL_MODULES as at that point we don't have the module in /lib
> - mv /install/modules/lib/modules/* /lib/modules/.
> - modprobe amdgpu
> + mv /install/modules/lib/modules/* /lib/modules/. || true
> + modprobe --first-time $DRIVER_NAME
> ;;
> esac
>
> diff --git a/drivers/gpu/drm/ci/image-tags.yml b/drivers/gpu/drm/ci/image-tags.yml
> index d8f72b82c938..fd1cb6061166 100644
> --- a/drivers/gpu/drm/ci/image-tags.yml
> +++ b/drivers/gpu/drm/ci/image-tags.yml
> @@ -4,9 +4,9 @@ variables:
> DEBIAN_BASE_TAG: "${CONTAINER_TAG}"
>
> DEBIAN_X86_64_BUILD_IMAGE_PATH: "debian/x86_64_build"
> - DEBIAN_BUILD_TAG: "2023-10-08-config"
> + DEBIAN_BUILD_TAG: "2024-04-22-virtio"
>
> - KERNEL_ROOTFS_TAG: "2023-10-06-amd"
> + KERNEL_ROOTFS_TAG: "2024-04-22-virtio"
> PKG_REPO_REV: "3cc12a2a"
>
> DEBIAN_X86_64_TEST_BASE_IMAGE: "debian/x86_64_test-base"
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 612c9ede3507..864ac3809d84 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -350,6 +350,7 @@ virtio_gpu:none:
> script:
> - ln -sf $CI_PROJECT_DIR/install /install
> - mv install/bzImage /lava-files/bzImage
> + - mkdir -p /lib/modules
> - mkdir -p $CI_PROJECT_DIR/results
> - ln -sf $CI_PROJECT_DIR/results /results
> - install/crosvm-runner.sh install/igt_runner.sh
> diff --git a/drivers/gpu/drm/ci/x86_64.config b/drivers/gpu/drm/ci/x86_64.config
> index 1cbd49a5b23a..78479f063e8e 100644
> --- a/drivers/gpu/drm/ci/x86_64.config
> +++ b/drivers/gpu/drm/ci/x86_64.config
> @@ -91,7 +91,7 @@ CONFIG_KVM=y
> CONFIG_KVM_GUEST=y
> CONFIG_VIRT_DRIVERS=y
> CONFIG_VIRTIO_FS=y
> -CONFIG_DRM_VIRTIO_GPU=y
> +CONFIG_DRM_VIRTIO_GPU=m
> CONFIG_SERIAL_8250_CONSOLE=y
> CONFIG_VIRTIO_NET=y
> CONFIG_VIRTIO_CONSOLE=y
next prev parent reply other threads:[~2024-04-30 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 9:11 [PATCH v1 0/5] drm/ci: uprev mesa and generate testlist Vignesh Raman
2024-04-30 9:11 ` [PATCH v1 1/5] drm/ci: uprev mesa version Vignesh Raman
2024-04-30 14:30 ` Helen Koike
2024-04-30 9:11 ` [PATCH v1 2/5] drm/ci: generate testlist from build Vignesh Raman
2024-04-30 10:17 ` Dmitry Baryshkov
2024-05-07 5:46 ` Vignesh Raman
2024-04-30 14:31 ` Helen Koike
2024-05-07 6:00 ` Vignesh Raman
2024-04-30 9:11 ` [PATCH v1 3/5] drm/ci: build virtual GPU driver as module Vignesh Raman
2024-04-30 14:31 ` Helen Koike [this message]
2024-04-30 9:11 ` [PATCH v1 4/5] drm/ci: skip driver specific tests Vignesh Raman
2024-04-30 10:09 ` Dmitry Baryshkov
2024-04-30 14:31 ` Helen Koike
2024-05-07 6:05 ` Vignesh Raman
2024-04-30 9:11 ` [PATCH v1 5/5] drm/ci: update xfails for the new testlist Vignesh Raman
2024-04-30 10:15 ` Dmitry Baryshkov
2024-05-07 6:07 ` Vignesh Raman
2024-04-30 14:31 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90a0b4ba-52e3-446e-8de1-ca67e0c71a53@collabora.com \
--to=helen.koike@collabora.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=david.heidelberg@collabora.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=guilherme.gallo@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mcanal@igalia.com \
--cc=robdclark@gmail.com \
--cc=sergi.blanch.torne@collabora.com \
--cc=vignesh.raman@collabora.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).