From: Doug Anderson <dianders@google.com>
To: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jikos@kernel.org, benjamin.tissoires@redhat.co,
hsinyi@google.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing
Date: Thu, 9 May 2024 07:34:56 -0700 [thread overview]
Message-ID: <CAD=FV=Ugm+-ziY+8f93KOChvmkbf_MdxEOoyJP5WJq70m-aOGQ@mail.gmail.com> (raw)
In-Reply-To: <20240509064336.9803-2-lvzhaoxiong@huaqin.corp-partner.google.com>
Hi,
On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv
<lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
>
> From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
>
> ILI2900 requires reset to pull down time greater than 10ms,
> so the configuration post_power_delay_ms is 10, and the chipset
> initial time is required to be greater than 100ms,
> so the post_gpio_reset_on_delay_ms is set to 100.
>
> Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
> ---
> drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
You silently ignored pretty much all of the feedback from the previous
version [1], so I'm not planning to review this version.
[1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com
next prev parent reply other threads:[~2024-05-09 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 6:43 [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 Zhaoxiong Lv
2024-05-09 6:43 ` [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing Zhaoxiong Lv
2024-05-09 14:34 ` Doug Anderson [this message]
2024-05-10 12:07 ` zhaoxiong lv
2024-05-09 6:48 ` [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 zhaoxiong lv
2024-05-09 8:17 ` Rob Herring (Arm)
2024-05-09 8:33 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2024-04-18 12:48 [PATCH v1 0/2] Add ili2900 timing lvzhaoxiong
2024-04-18 12:48 ` [PATCH v1 2/2] HID: i2c-hid: elan: " lvzhaoxiong
2024-04-19 20:41 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Ugm+-ziY+8f93KOChvmkbf_MdxEOoyJP5WJq70m-aOGQ@mail.gmail.com' \
--to=dianders@google.com \
--cc=benjamin.tissoires@redhat.co \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).