From: Doug Anderson <dianders@google.com>
To: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jikos@kernel.org, benjamin.tissoires@redhat.co,
hsinyi@google.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cong yang <yangcong5@huaqin.corp-partner.google.com>
Subject: Re: [PATCH v2 0/2] Add starry bindings and driver
Date: Thu, 9 May 2024 07:11:52 -0700 [thread overview]
Message-ID: <CAD=FV=VfBXjgYTzNEj+szHX9-wGig9XUFVt+CkG6mXzHwZjduw@mail.gmail.com> (raw)
In-Reply-To: <20240509083453.14073-1-lvzhaoxiong@huaqin.corp-partner.google.com>
Hi,
On Thu, May 9, 2024 at 1:35 AM Zhaoxiong Lv
<lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
>
> Add bindings and driver for starry.
> ---
> Modifications between V1 and V2:
> Kconfig and Makefile configurations added for starry driver
>
> ---
>
> Zhaoxiong Lv (2):
> dt-bindings: display: panel: Add Starry-er88577 support
> drm/panel: starry: add new panel driver
>
> .../display/panel/starry,er88577.yaml | 59 +++
> drivers/gpu/drm/panel/Kconfig | 9 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-starry-er88577.c | 444 ++++++++++++++++++
> 4 files changed, 513 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/starry,er88577.yaml
> create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c
I don't think anyone is going to look at this series since it's not
taking into account previous feedback. Please talk to Cong Yang (CCed)
who is also working at Huaquin and is also sending MIPI panel patches.
Hopefully he should be able to pre-review your patches with you so
that you can learn from what he learned. If for some reason you are
unable to work with Cong Yang then let me know and we can figure out
the next steps here.
-Doug
prev parent reply other threads:[~2024-05-09 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 8:34 [PATCH v2 0/2] Add starry bindings and driver Zhaoxiong Lv
2024-05-09 8:34 ` [PATCH v2 1/2] dt-bindings: display: panel: Add Starry-er88577 support Zhaoxiong Lv
2024-05-09 8:43 ` Krzysztof Kozlowski
2024-05-09 14:11 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VfBXjgYTzNEj+szHX9-wGig9XUFVt+CkG6mXzHwZjduw@mail.gmail.com' \
--to=dianders@google.com \
--cc=benjamin.tissoires@redhat.co \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
--cc=robh@kernel.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).