From: "Barnabás Czémán" <trabarni@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: jdi-fhd-r63452: move DCS off commands to disable
Date: Fri, 10 May 2024 08:46:54 +0200 [thread overview]
Message-ID: <CAGsSOWWAotJPz+o8HSYTrXtq6H7Vrw9KXZX1jDZLgqfudKsnyg@mail.gmail.com> (raw)
In-Reply-To: <rpita5o6za64p7tamasssb2fja6h6ipr5cibh6gs7klkijyk6r@mausrcet2ycx>
On Fri, May 10, 2024 at 2:56 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Thu, May 09, 2024 at 08:14:07PM +0200, Barnabás Czémán wrote:
> > Move DCS off commands from .unprepare to .disable so that they
> > actually reach the DSI host.
> >
> > Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> > ---
> > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
>
> I don't think this is correct. If the driver sends enable commands in
> prepare, it should be able to send commands during unprepare too.
>
It cannot send commands in unprepare, there are multiple panel drivers
what do the same.
Every panel drivers which have DCS commands to be sent in unprepare
has similar error messages with mdp5/dpu.
[ 92.322564] panel-td4320-boeplus c994000.dsi.0: sending command
0x28 failed: -22
[ 92.322635] panel-td4320-boeplus c994000.dsi.0: Failed to
un-initialize panel: -22
> >
> > diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> > index 483dc88d16d8..f7222974d6ed 100644
> > --- a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> > +++ b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> > @@ -169,6 +169,15 @@ static int jdi_fhd_r63452_prepare(struct drm_panel *panel)
> > }
> >
> > static int jdi_fhd_r63452_unprepare(struct drm_panel *panel)
> > +{
> > + struct jdi_fhd_r63452 *ctx = to_jdi_fhd_r63452(panel);
> > +
> > + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> > +
> > + return 0;
> > +}
> > +
> > +static int jdi_fhd_r63452_disable(struct drm_panel *panel)
> > {
> > struct jdi_fhd_r63452 *ctx = to_jdi_fhd_r63452(panel);
> > struct device *dev = &ctx->dsi->dev;
> > @@ -178,8 +187,6 @@ static int jdi_fhd_r63452_unprepare(struct drm_panel *panel)
> > if (ret < 0)
> > dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
> >
> > - gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> > -
> > return 0;
> > }
> >
> > @@ -219,6 +226,7 @@ static int jdi_fhd_r63452_get_modes(struct drm_panel *panel,
> > static const struct drm_panel_funcs jdi_fhd_r63452_panel_funcs = {
> > .prepare = jdi_fhd_r63452_prepare,
> > .unprepare = jdi_fhd_r63452_unprepare,
> > + .disable = jdi_fhd_r63452_disable,
> > .get_modes = jdi_fhd_r63452_get_modes,
> > };
> >
> >
> > ---
> > base-commit: 704ba27ac55579704ba1289392448b0c66b56258
> > change-id: 20240509-jdi-use-disable-ee29098d9c81
> >
> > Best regards,
> > --
> > Barnabás Czémán <trabarni@gmail.com>
> >
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2024-05-10 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 18:14 [PATCH] drm/panel: jdi-fhd-r63452: move DCS off commands to disable Barnabás Czémán
2024-05-10 0:56 ` Dmitry Baryshkov
2024-05-10 6:46 ` Barnabás Czémán [this message]
2024-05-10 7:10 ` Barnabás Czémán
2024-05-10 18:02 ` Dmitry Baryshkov
2024-05-10 21:43 ` Barnabás Czémán
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsSOWWAotJPz+o8HSYTrXtq6H7Vrw9KXZX1jDZLgqfudKsnyg@mail.gmail.com \
--to=trabarni@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).