* [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
@ 2024-02-19 12:01 Andy Yan
0 siblings, 0 replies; 5+ messages in thread
From: Andy Yan @ 2024-02-19 12:01 UTC (permalink / raw
To: heiko; +Cc: hjc, s.hauer, dri-devel, linux-arm-kernel, linux-kernel, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
index 48170694ac6b..18efb3fe1c00 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
@@ -17,9 +17,7 @@
static const uint32_t formats_cluster[] = {
DRM_FORMAT_XRGB2101010,
- DRM_FORMAT_ARGB2101010,
DRM_FORMAT_XBGR2101010,
- DRM_FORMAT_ABGR2101010,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_ARGB8888,
DRM_FORMAT_XBGR8888,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
@ 2024-03-04 10:09 Andy Yan
2024-03-04 10:40 ` Sascha Hauer
2024-03-26 8:53 ` Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Andy Yan @ 2024-03-04 10:09 UTC (permalink / raw
To: heiko
Cc: hjc, s.hauer, dri-devel, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
index 48170694ac6b..18efb3fe1c00 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
@@ -17,9 +17,7 @@
static const uint32_t formats_cluster[] = {
DRM_FORMAT_XRGB2101010,
- DRM_FORMAT_ARGB2101010,
DRM_FORMAT_XBGR2101010,
- DRM_FORMAT_ABGR2101010,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_ARGB8888,
DRM_FORMAT_XBGR8888,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
2024-03-04 10:09 [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support Andy Yan
@ 2024-03-04 10:40 ` Sascha Hauer
2024-03-23 10:10 ` Andy Yan
2024-03-26 8:53 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2024-03-04 10:40 UTC (permalink / raw
To: Andy Yan
Cc: heiko, hjc, dri-devel, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan
On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> The Alpha blending for 30 bit RGB/BGR are not
> functioning properly for rk3568/rk3588, so remove
> it from the format list.
>
> Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
>
> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> index 48170694ac6b..18efb3fe1c00 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> @@ -17,9 +17,7 @@
>
> static const uint32_t formats_cluster[] = {
> DRM_FORMAT_XRGB2101010,
> - DRM_FORMAT_ARGB2101010,
> DRM_FORMAT_XBGR2101010,
> - DRM_FORMAT_ABGR2101010,
> DRM_FORMAT_XRGB8888,
> DRM_FORMAT_ARGB8888,
> DRM_FORMAT_XBGR8888,
> --
> 2.34.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
2024-03-04 10:40 ` Sascha Hauer
@ 2024-03-23 10:10 ` Andy Yan
0 siblings, 0 replies; 5+ messages in thread
From: Andy Yan @ 2024-03-23 10:10 UTC (permalink / raw
To: Heiko Stuebner, Sascha Hauer
Cc: heiko, hjc, dri-devel, linux-arm-kernel, linux-kernel,
linux-rockchip
Hi Heiko,
Could you please to take a look at this patch?
On 3/4/24 18:40, Sascha Hauer wrote:
> On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> The Alpha blending for 30 bit RGB/BGR are not
>> functioning properly for rk3568/rk3588, so remove
>> it from the format list.
>>
>> Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> Sascha
>
>>
>> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> index 48170694ac6b..18efb3fe1c00 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> @@ -17,9 +17,7 @@
>>
>> static const uint32_t formats_cluster[] = {
>> DRM_FORMAT_XRGB2101010,
>> - DRM_FORMAT_ARGB2101010,
>> DRM_FORMAT_XBGR2101010,
>> - DRM_FORMAT_ABGR2101010,
>> DRM_FORMAT_XRGB8888,
>> DRM_FORMAT_ARGB8888,
>> DRM_FORMAT_XBGR8888,
>> --
>> 2.34.1
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
2024-03-04 10:09 [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support Andy Yan
2024-03-04 10:40 ` Sascha Hauer
@ 2024-03-26 8:53 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2024-03-26 8:53 UTC (permalink / raw
To: Andy Yan
Cc: Heiko Stuebner, linux-rockchip, hjc, Andy Yan, linux-kernel,
s.hauer, dri-devel, linux-arm-kernel
On Mon, 4 Mar 2024 18:09:52 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> The Alpha blending for 30 bit RGB/BGR are not
> functioning properly for rk3568/rk3588, so remove
> it from the format list.
>
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: vop2: Remove AR30 and AB30 format support
commit: 905f7d53a1bc105b22d9ffd03dc11b6b42ec6ba6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-26 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 10:09 [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support Andy Yan
2024-03-04 10:40 ` Sascha Hauer
2024-03-23 10:10 ` Andy Yan
2024-03-26 8:53 ` Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2024-02-19 12:01 Andy Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).