* Re: Khadas VIM3/3L New TS050 support patch
[not found] <d9b282de6a7846269b595d9bdae9102dTYZPR03MB7001ED3D869727EE9331530A803D2@TYZPR03MB7001.apcprd03.prod.outlook.com>
@ 2024-04-08 13:19 ` neil.armstrong
2024-04-09 8:31 ` Krzysztof Kozlowski
1 sibling, 0 replies; 2+ messages in thread
From: neil.armstrong @ 2024-04-08 13:19 UTC (permalink / raw
To: Jacobe Zang, narmstrong@baylibre.com, quic_jesszhan@quicinc.com,
sam@ravnborg.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Nick Xie
Hi Jacobe,
On 08/04/2024 15:16, Jacobe Zang wrote:
> Subject: [PATCH] drm/panel: add New TS050 Panel support
>
> Hello all,
>
> I have made some changes to the panel-khadas-ts050.c. Here is a brief overview of what has been done:
>
> - Add dt-bindings in document.
> - Add New TS050 Panel timing sequence.
> - Make it compatible with the old TS050 panel.
> - The only difference between them is the timing, so I change the node in overlay to identify the specific panel.
> - Changes in DTS doesn't push, because preceding commits have not been merged.
>
> The proposed changes have been successfully run on Khadas VIM3/3L.
>
> Please find the patch attached/inline.
You should read https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
and perhaps use a tool like b4 (https://b4.docs.kernel.org/en/latest/) to send your patches in text only,
you can follow https://www.marcusfolkesson.se/blog/use-b4-for-kernel-contributions/ for example.
I'm afraid this patchset will be rejected and not reviewed if sent in this format with patches as attachments.
Thanks,
Neil
>
> Jacobe Zang (2):
> drm/panel: add New TS050 panel support
> dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c | 1119 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------
> Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
>
> ---
> Best Regards
> Jacobe 臧介皓
> Amazing Khadas, Always Amazes You!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Khadas VIM3/3L New TS050 support patch
[not found] <d9b282de6a7846269b595d9bdae9102dTYZPR03MB7001ED3D869727EE9331530A803D2@TYZPR03MB7001.apcprd03.prod.outlook.com>
2024-04-08 13:19 ` Khadas VIM3/3L New TS050 support patch neil.armstrong
@ 2024-04-09 8:31 ` Krzysztof Kozlowski
1 sibling, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-09 8:31 UTC (permalink / raw
To: Jacobe Zang, narmstrong@baylibre.com, quic_jesszhan@quicinc.com,
sam@ravnborg.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Nick Xie
On 08/04/2024 15:16, Jacobe Zang wrote:
> Subject: [PATCH] drm/panel: add New TS050 Panel support
>
> Hello all,
>
> I have made some changes to the panel-khadas-ts050.c. Here is a brief overview of what has been done:
>
> - Add dt-bindings in document.
> - Add New TS050 Panel timing sequence.
> - Make it compatible with the old TS050 panel.
> - The only difference between them is the timing, so I change the node in overlay to identify the specific panel.
> - Changes in DTS doesn't push, because preceding commits have not been merged.
>
I cannot review attachments, but anyway:
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-09 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <d9b282de6a7846269b595d9bdae9102dTYZPR03MB7001ED3D869727EE9331530A803D2@TYZPR03MB7001.apcprd03.prod.outlook.com>
2024-04-08 13:19 ` Khadas VIM3/3L New TS050 support patch neil.armstrong
2024-04-09 8:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).