From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Benjamin Philip <benjamin.philip495@gmail.com>
Cc: devel mailing list <devel@linuxdriverproject.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c
Date: Tue, 27 Jul 2021 15:17:08 +0200 [thread overview]
Message-ID: <YQAHVHGs7/vB4Ofx@kroah.com> (raw)
In-Reply-To: <cover.1627029208.git.benjamin.philip495@gmail.com>
On Fri, Jul 23, 2021 at 04:27:50PM +0530, Benjamin Philip wrote:
> The following few patches remove some blank lines that before or after a brace.
>
> To test my changes, I have checked if it compiles (which it does). I also have
> checked the patch with checkpatch.pl, which does not pass any warnings of any sort.
>
> Changes in v2:
> * Tested by building (no changes code)
>
> This is my first patch to the linux kernel. I apologize for all the inconveniences caused
> by my unfamiliarity with the kernel workflow.
>
> I also have split each line I removed into a patch so that it is convenient for the
> maintainer. I hope it is so.
>
> Thanks,
> Benjamin Philip
>
> Benjamin Philip (3):
> staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385
> staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457
> staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143
That's just too many patches, your first one was just fine :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2021-07-27 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 10:57 [PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c Benjamin Philip
2021-07-23 10:57 ` [PATCH v2 1/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385 Benjamin Philip
2021-07-23 10:57 ` [PATCH v2 2/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457 Benjamin Philip
2021-07-23 10:57 ` [PATCH v2 3/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143 Benjamin Philip
2021-07-27 13:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQAHVHGs7/vB4Ofx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=benjamin.philip495@gmail.com \
--cc=devel@linuxdriverproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).