Dwarves Archive mirror
 help / color / mirror / Atom feed
From: Bill Wendling <morbo@google.com>
To: dwarves@vger.kernel.org
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Fangrui Song <maskray@google.com>,
	Bill Wendling <morbo@google.com>
Subject: [PATCH dwarves 0/1] LLD .BTF section patch
Date: Tue, 22 Nov 2022 00:00:10 +0000	[thread overview]
Message-ID: <20221122000011.241697-1-morbo@google.com> (raw)

This patch is an attempted fix for the issue discussed in [1]. I believe it's
actually caused by pahole generating a corrupted ELF file.

LLD generates a zero-sized .BTF section, while BFD doesn't. When pahole goes to
add the .BTF data to an LLD-generated file, the section exists, but is too
small. The ELF calls don't appear to adjust following sections' addresses in
this case.

To avoid this, the patch does some magic with objcopy to generate a separate
.BTF section and perform some renaming.

NOTE: This patch resembles a hack. If it's possible to adjust a section's size
with ELF calls we should do it that way.

[1]: https://lore.kernel.org/dwarves/20210317232657.mdnsuoqx6nbddjgt@google.com/

Bill Wendling (1):
  btf_encoder: Generate a new .BTF section even if one exists

 btf_encoder.c | 88 +++++++++++++++++++++++++++++++--------------------
 1 file changed, 54 insertions(+), 34 deletions(-)

-- 
2.38.1.584.g0f3c55d4c2-goog


             reply	other threads:[~2022-11-22  0:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  0:00 Bill Wendling [this message]
2022-11-22  0:00 ` [PATCH 1/1] btf_encoder: Generate a new .BTF section even if one exists Bill Wendling
2022-11-30 22:59   ` Andrii Nakryiko
2022-12-01  0:21     ` Bill Wendling
2022-12-01 19:56       ` Andrii Nakryiko
2022-12-01 20:19         ` Bill Wendling
2022-12-06 18:38           ` Andrii Nakryiko
2022-12-06 18:43             ` Andrii Nakryiko
2022-12-06 20:15             ` Bill Wendling
2022-12-06 22:52               ` Andrii Nakryiko
2022-12-07 20:16                 ` Bill Wendling
2022-12-07 20:33                   ` Andrii Nakryiko
2022-12-15 23:00                     ` Bill Wendling
2022-12-16  0:09                       ` Bill Wendling
2022-12-20 22:00                         ` Andrii Nakryiko
2022-11-28 20:20 ` [PATCH dwarves 0/1] LLD .BTF section patch Bill Wendling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122000011.241697-1-morbo@google.com \
    --to=morbo@google.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=dwarves@vger.kernel.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).