From: Tyler Hicks <tyhicks@canonical.com>
To: Wenwen Wang <wenwen@cs.uga.edu>
Cc: "open list:ECRYPT FILE SYSTEM" <ecryptfs@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ecryptfs: fix a memory leak bug
Date: Tue, 20 Aug 2019 00:11:32 -0700 [thread overview]
Message-ID: <20190820071131.GB22824@elm> (raw)
In-Reply-To: <1566279234-9634-1-git-send-email-wenwen@cs.uga.edu>
On 2019-08-20 00:33:54, Wenwen Wang wrote:
> In ecryptfs_init_messaging(), if the allocation for 'ecryptfs_msg_ctx_arr'
> fails, the previously allocated 'ecryptfs_daemon_hash' is not deallocated,
> leading to a memory leak bug. To fix this issue, free
> 'ecryptfs_daemon_hash' before returning the error.
>
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Thanks for the patch!
I added the following tags to the commit message:
Cc: stable@vger.kernel.org
Fixes: 88b4a07e6610 ("[PATCH] eCryptfs: Public key transport mechanism")
I also added the function name to the commit subject so that it was
unique from your other fix.
I've pushed the fix to the eCryptfs next branch and I'll submit a pull
request for inclusion soon.
Tyler
> ---
> fs/ecryptfs/messaging.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> index d668e60..c05ca39 100644
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -379,6 +379,7 @@ int __init ecryptfs_init_messaging(void)
> * ecryptfs_message_buf_len),
> GFP_KERNEL);
> if (!ecryptfs_msg_ctx_arr) {
> + kfree(ecryptfs_daemon_hash);
> rc = -ENOMEM;
> goto out;
> }
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-08-20 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 5:33 [PATCH] ecryptfs: fix a memory leak bug Wenwen Wang
2019-08-20 7:11 ` Tyler Hicks [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-20 5:16 Wenwen Wang
2019-08-20 7:10 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820071131.GB22824@elm \
--to=tyhicks@canonical.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).